Skip to content

Commit e5d2e92

Browse files
committed
chore: optimize
1 parent 3ba4303 commit e5d2e92

File tree

5 files changed

+1
-64
lines changed

5 files changed

+1
-64
lines changed

packages/@iris/rtc/generate/IAgoraRtcEngine.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1395,8 +1395,6 @@ export class ExtensionInfo {
13951395
}
13961396

13971397
export interface IRtcEngine {
1398-
release(sync: boolean): CallApiReturnType;
1399-
14001398
initialize(context: RtcEngineContext): CallApiReturnType;
14011399

14021400
queryInterface(iid: INTERFACE_ID_TYPE, inter: any): CallApiReturnType;

packages/rtc/src/binding/IAgoraRtcEngineDispatch.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2037,18 +2037,6 @@ export class IRtcEngineDispatch implements IRtcEngine {
20372037
this._impl = new IRtcEngineImpl(engine);
20382038
this._engine = engine;
20392039
}
2040-
// @ts-ignore
2041-
release(apiParam: ApiParam): CallApiReturnType {
2042-
let obj = JSON.parse(apiParam.data) as any;
2043-
let sync = obj.sync;
2044-
if (sync === undefined) {
2045-
AgoraConsole.error('sync is undefined');
2046-
throw 'sync is undefined';
2047-
}
2048-
2049-
return this._impl.release(sync);
2050-
}
2051-
20522040
// @ts-ignore
20532041
initialize(apiParam: ApiParam): CallApiReturnType {
20542042
let obj = JSON.parse(apiParam.data) as any;

packages/rtc/src/util/iris_rtc_api_type_gen.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -580,7 +580,6 @@ export const IDIRECTCDNSTREAMINGEVENTHANDLER_ONDIRECTCDNSTREAMINGSTATECHANGED =
580580
'DirectCdnStreamingEventHandler_onDirectCdnStreamingStateChanged';
581581
export const IDIRECTCDNSTREAMINGEVENTHANDLER_ONDIRECTCDNSTREAMINGSTATS =
582582
'DirectCdnStreamingEventHandler_onDirectCdnStreamingStats';
583-
export const IRTCENGINE_RELEASE = 'RtcEngine_release';
584583
export const IRTCENGINE_INITIALIZE = 'RtcEngine_initialize';
585584
export const IRTCENGINE_QUERYINTERFACE = 'RtcEngine_queryInterface';
586585
export const IRTCENGINE_GETVERSION = 'RtcEngine_getVersion';

packages/rtc/test/binding/IAgoraRtcEngineDispatch.test.ts

Lines changed: 0 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -2605,55 +2605,6 @@ describe('IDirectCdnStreamingEventHandler', () => {
26052605
});
26062606
});
26072607
describe('IRtcEngine', () => {
2608-
test('RtcEngine_release parameter', async () => {
2609-
let nParam = {
2610-
sync: undefined,
2611-
};
2612-
try {
2613-
await IrisCore.callIrisApi(
2614-
apiEnginePtr,
2615-
new IrisCore.EventParam(
2616-
'RtcEngine_release',
2617-
JSON.stringify(nParam),
2618-
0,
2619-
'',
2620-
['test'],
2621-
[],
2622-
1
2623-
)
2624-
);
2625-
} catch (e) {
2626-
expect(e).toEqual('sync is undefined');
2627-
}
2628-
//@ts-ignore
2629-
nParam.sync = 'test';
2630-
});
2631-
2632-
test('RtcEngine_release impl call', async () => {
2633-
jest
2634-
.spyOn(irisRtcEngine.implDispatchesMap.get('RtcEngine')._impl, 'release')
2635-
.mockResolvedValue(new CallIrisApiResult(0, ''));
2636-
let nParam = {
2637-
sync: 'test',
2638-
};
2639-
let apiParam = new IrisCore.EventParam(
2640-
'RtcEngine_release',
2641-
JSON.stringify(nParam),
2642-
0,
2643-
'',
2644-
['test'],
2645-
[],
2646-
1
2647-
);
2648-
await IrisCore.callIrisApi(apiEnginePtr, apiParam);
2649-
expect(
2650-
irisRtcEngine.implDispatchesMap.get('RtcEngine')._impl.release
2651-
).toBeCalledTimes(1);
2652-
expect(
2653-
irisRtcEngine.implDispatchesMap.get('RtcEngine')._impl.release
2654-
).toBeCalledWith('test');
2655-
});
2656-
26572608
test('RtcEngine_initialize parameter', async () => {
26582609
let nParam = {
26592610
context: undefined,

scripts/terra/config/remove_node_list.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ module.exports = [
7070
'agora::rtc::IRtcEngineEx.createDataStreamEx.streamId',
7171
'agora::rtc::IRtcEngine.getVersion.build',
7272
'agora::rtc::IRtcEngine.takeSnapshot.callback',
73+
'agora::rtc::IRtcEngine.release',
7374
'agora::rtc::ICloudSpatialAudioEngine.getTeammates.uids',
7475
'agora::rtc::ICloudSpatialAudioEngine.getTeammates.userCount',
7576
'agora::rtc::ILocalSpatialAudioEngine.initialize.config',

0 commit comments

Comments
 (0)