Merge pull request #353 from AhmedLSayed9/add_semantics_to_dropdown_items

Add semantics to dropdown menu items [Flutter core]

Author: AhmedLSayed9

packages/dropdown_button2/CHANGELOG.md

@@ -7,6 +7,7 @@
 - Implement switch expressions.
 - Fix memory leak in CurvedAnimation [Flutter core].
 - Avoid Container objects when possible for better performance [Flutter core].
+- Add semantics to dropdown menu items [Flutter core].
 
 ## 3.0.0-beta.21
 

packages/dropdown_button2/lib/src/dropdown_button2.dart

@@ -882,8 +882,10 @@ class _DropdownButton2State<T> extends State<DropdownButton2<T>>
       );
     }
 
+    final bool childHasButtonSemantic = hintIndex != null ||
+        (_selectedIndex != null && widget.selectedItemBuilder == null);
     return Semantics(
-      button: true,
+      button: !childHasButtonSemantic,
       child: Actions(
         actions: _actionMap,
         child: InkWell(

packages/dropdown_button2/lib/src/dropdown_menu_item.dart

@@ -111,9 +111,12 @@ class _DropdownMenuItemContainer extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    return SizedBox(
-      height: intrinsicHeight ? null : height,
-      child: Align(alignment: alignment, child: child),
+    return Semantics(
+      button: true,
+      child: SizedBox(
+        height: intrinsicHeight ? null : height,
+        child: Align(alignment: alignment, child: child),
+      ),
     );
   }
 }