CWE79++

Aif4thah · Aif4thah · commit 7a0fb1a682bc · 2025-05-15T15:29:53.000+02:00
diff --git a/Controller/Controller.cs b/Controller/Controller.cs
@@ -106,17 +106,6 @@ Parse les contrats au format XML passées en paramètre et retourne son contenu
             }
         }
 
-        public static void VulnerableLogs(string Str, string LogFile)
-        {
-            /*
-            Enregistre la chaine de caractères passée en paramètre dans le fichier de journalisation
-            */
-            if (Str.Contains("script", StringComparison.OrdinalIgnoreCase)) Str = HttpUtility.HtmlEncode(Str);
-            if (!File.Exists(LogFile)) File.WriteAllText(LogFile, Data.GetLogPage());
-            string Page = File.ReadAllText(LogFile).Replace("</body>", $"<p>{Str}</p><br>{Environment.NewLine}</body>");
-            File.WriteAllText(LogFile, Page);
-        }
-
         public static async Task<object> VulnerableWebRequest(string Uri = "https://localhost:3000/")
         {
             /*
diff --git a/Identity/VLAIdentity.cs b/Identity/VLAIdentity.cs
@@ -37,7 +37,6 @@ public static async Task<object> VulnerableQuery(string User, string Passwd)
             for (int i = 0; i < Bytes.Length; i++) stringbuilder.Append(Bytes[i].ToString("x2"));
             string Hash = stringbuilder.ToString();
 
-            VLAController.VLAController.VulnerableLogs("login attempt for:\n" + User + "\n" + Passwd + "\n", LogFile);
             var DataSet = VLAModel.Data.GetDataSet();
             var Result = DataSet.Tables[0].Select("Passwd = '" + Hash + "' and User = '" + User + "'");
             var userRow = DataSet.Tables[0].AsEnumerable().FirstOrDefault(row => row.Field<string>("User") == User && row.Field<int>("IsAdmin") == 1);
diff --git a/MidlWare/MidlWare.cs b/MidlWare/MidlWare.cs
@@ -4,6 +4,7 @@
 using Microsoft.IdentityModel.Tokens;
 using Microsoft.AspNetCore.Http;
 using System.Text;
+using System.Web;
 
 namespace VulnerableWebApplication.MidlWare
 {
@@ -40,40 +41,57 @@ public ValidateJwtMiddleware(RequestDelegate next)
         public async Task InvokeAsync(HttpContext context, IConfiguration configuration)
         {
             /*
-                Authentifie les utilisateurs
-            */
+             * Authentifie les utilisateur
+             * 
+             * Renvoi certains messages d'érreur
+             */
+            var path = context.Request.Path.Value;
+            if (path.Contains("script", StringComparison.OrdinalIgnoreCase)) path = HttpUtility.HtmlEncode(path); //XSS protection ;)
 
             string authHeader = context.Request.Headers["Authorization"];
-            string UnauthMsg = "Welcome to vulnerableLightApp. You are not authenticated. Source code is available at https://github.com/Aif4thah/VulnerableLightApp";
 
-            // URL Without Authentication
-            var path = context.Request.Path.Value;
+            string UnauthMsg = "<html><head><title>Accès interdit</title></head>" +
+                               "<body><h1>Erreur 401 - Accès non autorisé</h1>" +
+                               "<p>START HACKING !</p></body></html>";
+
+            string NotFoundMsg = "<html><head><title>Page introuvable</title></head>" +
+                                 "<body><h1>Erreur 404 - Page non trouvée</h1>" +
+                                 "<p>La ressource " + path + " n'existe pas ou a été déplacée.</p></body></html>";
+
             if (path.Equals("/login", StringComparison.OrdinalIgnoreCase) || path.StartsWith("/swagger", StringComparison.OrdinalIgnoreCase))
             {
                 await _next(context);
                 return;
             }
 
-            // User Authentication
             if (string.IsNullOrEmpty(authHeader) || !VLAIdentity.VLAIdentity.VulnerableValidateToken(authHeader, configuration["Secret"]))
             {
                 context.Response.StatusCode = StatusCodes.Status401Unauthorized;
-                var bytes = Encoding.UTF8.GetBytes(UnauthMsg);
-                context.Response.Body.WriteAsync(bytes, 0, bytes.Length);
+                context.Response.ContentType = "text/html; charset=utf-8";
+                await context.Response.WriteAsync(UnauthMsg, Encoding.UTF8);
                 return;
             }
 
-            // Admin Authentication
-            if (path.StartsWith("/Patch", StringComparison.OrdinalIgnoreCase) && (string.IsNullOrEmpty(authHeader) || !VLAIdentity.VLAIdentity.VulnerableAdminValidateToken(authHeader, configuration["Secret"])) )
+            if (path.StartsWith("/Patch", StringComparison.OrdinalIgnoreCase) && (string.IsNullOrEmpty(authHeader) || !VLAIdentity.VLAIdentity.VulnerableAdminValidateToken(authHeader, configuration["Secret"])))
             {
                 context.Response.StatusCode = StatusCodes.Status401Unauthorized;
-                var bytes = Encoding.UTF8.GetBytes(UnauthMsg);
-                context.Response.Body.WriteAsync(bytes, 0, bytes.Length);
+                context.Response.ContentType = "text/html; charset=utf-8";
+                await context.Response.WriteAsync(UnauthMsg, Encoding.UTF8);
                 return;
             }
 
             await _next(context);
+
+            // 🔹 Gestion du 404 après exécution du pipeline
+            if (context.Response.StatusCode == StatusCodes.Status404NotFound)
+            {
+                context.Response.ContentType = "text/html; charset=utf-8";
+                await context.Response.WriteAsync(NotFoundMsg, Encoding.UTF8);
+            }
         }
+
+
+
     }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -106,17 +106,6 @@ Parse les contrats au format XML passées en paramètre et retourne son contenu`
`106`	`106`	`}`
`107`	`107`	`}`
`108`	`108`
`109`		`- public static void VulnerableLogs(string Str, string LogFile)`
`110`		`- {`
`111`		`- /*`
`112`		`- Enregistre la chaine de caractères passée en paramètre dans le fichier de journalisation`
`113`		`- */`
`114`		`- if (Str.Contains("script", StringComparison.OrdinalIgnoreCase)) Str = HttpUtility.HtmlEncode(Str);`
`115`		`- if (!File.Exists(LogFile)) File.WriteAllText(LogFile, Data.GetLogPage());`
`116`		`- string Page = File.ReadAllText(LogFile).Replace("</body>", $"<p>{Str}</p><br>{Environment.NewLine}</body>");`
`117`		`- File.WriteAllText(LogFile, Page);`
`118`		`- }`
`119`		`-`
`120`	`109`	`public static async Task<object> VulnerableWebRequest(string Uri = "https://localhost:3000/")`
`121`	`110`	`{`
`122`	`111`	`/*`