Skip to content

node18 should be node20 #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hongbo-miao opened this issue Jan 3, 2024 · 2 comments · May be fixed by #174
Open

node18 should be node20 #173

hongbo-miao opened this issue Jan 3, 2024 · 2 comments · May be fixed by #174

Comments

@hongbo-miao
Copy link

hongbo-miao commented Jan 3, 2024 •
edited
Loading

After upgrading to v3.13.14, it breaks. 🥲

Got error:

Download action repository 'actions/checkout@v4' (SHA:b4ffde65f46336ab88eb53be808477a3936bae11)
Download action repository 'actions/setup-node@v4' (SHA:b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8)
Download action repository 'akhileshns/[email protected]' (SHA:74c2affebaa8010fb38a7ff9bb4568d57fd4fdf2)
Error: System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter ''using: node18' is not supported, use 'docker', 'node12', 'node16' or 'node20' instead.')
   at GitHub.Runner.Worker.ActionManifestManager.ConvertRuns(IExecutionContext executionContext, TemplateContext templateContext, TemplateToken inputsToken, String fileRelativePath, MappingToken outputs)
   at GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext executionContext, String manifestFile)
Error: Fail to load akhileshns/heroku-deploy/v3.13.14/action.yml

Note

Parameter ''using: node18' is not supported, use 'docker', 'node12', 'node16' or 'node20' instead.'

inside.

So I think node18 should be upgraded to node20 directly which is Node.js latest LTS version as of today:

image
@hongbo-miao hongbo-miao linked a pull request Jan 3, 2024 that will close this issue
Open
@hongbo-miao
Copy link
Author

@AkhileshNS

textbook added a commit to CodeYourFuture/tech-products-demo that referenced this issue Jan 3, 2024
@textbook
Pin Heroku Deploy action
0d3303a 
Pending fix for AkhileshNS/heroku-deploy#173
textbook added a commit to CodeYourFuture/tech-products-demo that referenced this issue Jan 3, 2024
@textbook
Pin Heroku Deploy action
45e5164 
Pending fix for AkhileshNS/heroku-deploy#173
@AkhileshNS
Copy link
Owner

Updated to version node20 in the latest version (v3.13.15), apologies for the slip up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: upgrade to node20 hongbo-miao/heroku-deploy
2 participants
@hongbo-miao @AkhileshNS