Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata may not be needed #10

Closed
AlenkaF opened this issue Aug 26, 2021 · 2 comments
Closed

Metadata may not be needed #10

AlenkaF opened this issue Aug 26, 2021 · 2 comments

Comments

@AlenkaF
Copy link
Owner

AlenkaF commented Aug 26, 2021

Check if the use of metadata is not necessary

It is possible to use the info of categories from the columns like this:

self._col.df.some_function()

without needing to specify the metadada.

@AlenkaF
Copy link
Owner Author

AlenkaF commented Sep 1, 2021

The metadata for categories is not needed. I deleted all usage of it and used self._col.df.some_function() to retrieve the info about categorical columns.

See research Notebook.

What needed to be done also is to separately define the dtype for categorical columns (in Vaex dtype of a categorical column is the dtype of data itself). I am not sure if the default is correct:

(_DtypeKind.CATEGORICAL, 64, 'u', '=')

# Categorical
# If it is internal, kind is categorical (23)
# If it is external (call from_dataframe) must give data dtype
if self._col.df.is_category(self._col):
return (_DtypeKind.CATEGORICAL, 64, 'u', '=') # what should be the default??

@AlenkaF AlenkaF mentioned this issue Sep 2, 2021
3 tasks
@AlenkaF
Copy link
Owner Author

AlenkaF commented Sep 2, 2021

Will deal with categorical dtype in #5.

@AlenkaF AlenkaF closed this as completed Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant