Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompilation warnings in package extensions #162

Open
epatters opened this issue Oct 26, 2023 · 11 comments
Open

Precompilation warnings in package extensions #162

epatters opened this issue Oct 26, 2023 · 11 comments
Labels
bug Something isn't working

Comments

@epatters
Copy link
Member

epatters commented Oct 26, 2023

When precompiling the OrdinaryDiffEq and ModelingToolkit extensions, I get the following warnings:

  2 dependencies had warnings during precompilation:
┌ AlgebraicPetriModelingToolkitExt [64666759-9bd1-54ef-b315-8c08f09f6f3d]
│  WARNING: Method definition (::Type{SciMLBase.ODEProblem{uType, tType, isinplace, P, F, K, PT} where PT where K where F where P where isinplace where tType where uType})(AlgebraicPetri.AbstractPetriNet{S, Ts, P} where P where Ts where S, Any) in module AlgebraicPetriOrdinaryDiffEqExt at /home/epatters/Local/algjulia/algpetri/ext/AlgebraicPetriOrdinaryDiffEqExt.jl:7 overwritten in module AlgebraicPetriModelingToolkitExt at /home/epatters/Local/algjulia/algpetri/ext/AlgebraicPetriModelingToolkitExt.jl:47.
│    ** incremental compilation may be fatally broken for this module **
└  
┌ AlgebraicPetriCatalystExt [77e4b18c-d989-5097-a0f2-659ba3bbce58]
│  WARNING: Method definition (::Type{SciMLBase.ODEProblem{uType, tType, isinplace, P, F, K, PT} where PT where K where F where P where isinplace where tType where uType})(AlgebraicPetri.AbstractPetriNet{S, Ts, P} where P where Ts where S, Any) in module AlgebraicPetriOrdinaryDiffEqExt at /home/epatters/Local/algjulia/algpetri/ext/AlgebraicPetriOrdinaryDiffEqExt.jl:7 overwritten in module AlgebraicPetriModelingToolkitExt at /home/epatters/Local/algjulia/algpetri/ext/AlgebraicPetriModelingToolkitExt.jl:47.
│    ** incremental compilation may be fatally broken for this module **
│  
│  WARNING: Method definition (::Type{SciMLBase.ODEProblem{uType, tType, isinplace, P, F, K, PT} where PT where K where F where P where isinplace where tType where uType})(AlgebraicPetri.AbstractPetriNet{S, Ts, P} where P where Ts where S, Any) in module AlgebraicPetriOrdinaryDiffEqExt at /home/epatters/Local/algjulia/algpetri/ext/AlgebraicPetriOrdinaryDiffEqExt.jl:7 overwritten in module AlgebraicPetriModelingToolkitExt at /home/epatters/Local/algjulia/algpetri/ext/AlgebraicPetriModelingToolkitExt.jl:47.
│    ** incremental compilation may be fatally broken for this module **

This is on Catlab v0.15.5.

@epatters epatters added the bug Something isn't working label Oct 26, 2023
@mehalter

This comment was marked as off-topic.

@mehalter

This comment was marked as off-topic.

@mehalter

This comment was marked as off-topic.

@epatters
Copy link
Member Author

julia> import OrdinaryDiffEq, ModelingToolkit

julia> OrdinaryDiffEq.ODEProblem === ModelingToolkit.ODEProblem
true

Is this equality a recent change? It would explain why the extensions are stomping on each other.

@mehalter

This comment was marked as off-topic.

@mehalter

This comment was marked as off-topic.

@mehalter

This comment was marked as off-topic.

@mehalter

This comment was marked as off-topic.

@mehalter
Copy link
Member

Sorry for the noise here! I marked my previous comments all off topic

@joshday
Copy link

joshday commented Feb 27, 2024

It looks like this severely stalls the precompilation of SimulationService.jl. I get a fun mix of warnings and errors. Happy to share the terminal output if it will help.

@jpfairbanks
Copy link
Member

Closed by #167 as soon as tests pass!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants