Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect example for onStubActivation on Usage Examples page #333

Open
6 of 9 tasks
kirilstrax opened this issue Oct 25, 2020 · 0 comments
Open
6 of 9 tasks

Incorrect example for onStubActivation on Usage Examples page #333

kirilstrax opened this issue Oct 25, 2020 · 0 comments

Comments

@kirilstrax
Copy link

New Issue Checklist

Environment

  • version of OHHTTPStubs: 8.0.0
  • integration method you are using:
    • Cocoapods
    • Carthage
    • submodule
    • other
  • version of the tool you use: not applicable

Issue Description

The example on Usage Examples page is shown as follows:

// Swift
OHHTTPStubs.onStubActivation() { request, stub in
  println("\(request.URL!) stubbed by \(stub.name).")
}

Problem 1: Signature of onStubActivation was changed a few versions ago. So it should be:

OHHTTPStubs.onStubActivation() { request, stub, response in

This problem applies to both, Swift and Objective C examples

Problem 2: replace println with print in Swift, as there's no println function in swift.

Problem 3: in Swift, NSURLRequest is bridged as URLRequest, and instead of request.URL!, it uses lower-cased request.url!

Bottom line: example in Swift should look something like this:

// Swift
OHHTTPStubs.onStubActivation() { request, stub, response in
  print("\(request.url!) stubbed by \(stub.name) of size \(response.dataSize).")
}
Complete output when you encounter the issue (if any)

This is documentation update issue, so not applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant