Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: test the accuracy of agent after incorporating linter result to the file_editor #4636

Open
xingyaoww opened this issue Oct 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@xingyaoww
Copy link
Contributor

xingyaoww commented Oct 30, 2024

What problem or use case are you trying to solve?

Currently, our str_replace_editor (https://github.com/All-Hands-AI/OpenHands/tree/main/openhands/runtime/plugins/agent_skills/file_editor/impl.py) performs edit, but doesn't really do any linter checks.

Describe the UX of the solution you'd like

Every time an edit is performed inside file_editor, the linter will be run and print out linter outputs to STDOUT.

Do you have thoughts on the technical implementation?

  • See tests/unit/linters/test_lint_diff.py about how to use the current OpenHands Linter
  • Change the EditTool in openhands/runtime/plugins/agent_skills/file_editor/impl.py by importing, and initializing Linter. Then run the linter whenever an edit is performed, and concatenate linter error results if there's a linter error.
@xingyaoww xingyaoww added the enhancement New feature or request label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant