Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Error in Patch Size during Tokenization #23

Open
JeremyCJM opened this issue Sep 12, 2024 · 1 comment
Open

Possible Error in Patch Size during Tokenization #23

JeremyCJM opened this issue Sep 12, 2024 · 1 comment

Comments

@JeremyCJM
Copy link

Should the patch_size here be 16 in Chameleon?

@ChrisLiu6
Copy link
Contributor

ChrisLiu6 commented Sep 12, 2024

I agree that this is confusing and maybe I should have used a better naming, but it is not a bug. This patch_size property is not designed to express the downsample ratio of vae, but is instead designed for the image size indicator tokens and serves as the basic unit to measure the size of images. Specifically, if you add the width indicator token id by 1, the width that it actually presents increases by 32 pixel when self.patch_size==32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants