-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure what we should or want to do regarding the plink functionality #11
Comments
There is a Python package for PLINK BED files https://pypi.org/project/bed-reader/ - should we just use that and build a converter? This is Python only code I think, so might be less efficient than what David wrote for alphaplinkpython, but by using “established” Python solution we get OS portability and speed ups and fixes from upstream when they occur. FYI Python/Rust extension for PLINK at https://towardsdatascience.com/nine-rules-for-writing-python-extensions-in-rust-d35ea3a4ec29, but that should be for the Python package! |
@gregorgorjanc I read about the package, and I think the advantages of using it might be:
The disadvantages are:
Overall, I think it should be a good option for the Alphatools. |
@XingerTang thanks for exploring these pros and cons!!! I am leaning to using the bed-reader, BUT I guess we would still need some sort of a converter to our format!? |
@gregorgorjanc Yes, we need a converter, but as data are stored in numpy arrays for both, I guesss it won't be too complicated. |
I saw your reference to bed-reader@ . Thank for you for considering its use! Inspired by @XingerTang's comments, I've updated the project so that it only (by default) depends on numpy. The dependency on pooch is now optional (needed only if you want to download my sample files). The dependencies on pandas and chatdet are gone. There is new optional dependency on scipy, but it is only needed if you want to create scipy sparse matrices. The new version is on PyPi in beta. You can install it with:
The beta documentation is here: https://fastlmm.github.io/bed-reader/beta/. If you have any questions or suggestions, just let me know. -- Carl |
Maybe we look into sgkit https://github.com/pystatgen/sgkit |
See
https://pypi.org/project/alphaplinkpython/
https://bitbucket.org/hickeyjohnteam/alphaplinkpython
The text was updated successfully, but these errors were encountered: