feat: TokenGenerator | Personal token #1525
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1524 - Added new TokenGeneratorController - Added new RegisterService for party info lookup - Moved existing token building logic from AuthenticationController to a new TokenService
jonkjetiloye
commented
Oct 4, 2025
| /// <param name="cancellationToken">Cancellation token</param> | ||
| /// <returns>A personal access token for the user</returns> | ||
| [HttpGet()] | ||
| [Route("personaltoken")] |
Member
Author
There was a problem hiding this comment.
Hvordan skal vi låse ned dette til bare test-miljøer?
Skal det være åpent i test-miljøer eller kreve noe autentisering for å få tilgang?
jonkjetiloye
commented
Oct 4, 2025
| Content = JsonContent.Create(body) | ||
| }; | ||
|
|
||
| var response = await httpClient.SendAsync(request, HttpCompletionOption.ResponseContentRead, cancellationToken); |
Member
Author
There was a problem hiding this comment.
Ikke forstått hva som må til for at platformtoken blir lagt på automatisk gjennom servicedefaults httpclient implementasjonen. Har lokalt testet med å legge på ekstra headere så lenge
jonkjetiloye
commented
Oct 4, 2025
jonkjetiloye
commented
Oct 4, 2025
| var partyinfo = await registerService.GetParty(pid, cancellationToken); | ||
| if (!partyinfo.Success || partyinfo.Party == null) | ||
| { | ||
| return NotFound($"No party found for pid {pid}"); |
Member
Author
There was a problem hiding this comment.
BadRequest and ProblemDetails plz
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Verification
Documentation