Bugfix - AccessMgmt - ClientDelegation - ReturnModel (#494)

* Update DelegationService.cs

More info in exceptions

* Fixed bug in Get - new return model

Author: Thuen

src/apps/Altinn.AccessManagement/src/Altinn.AccessManagement/Controllers/SystemUserClientDelegationController.cs

@@ -45,6 +45,7 @@ IAssignmentRepository assignmentRepository
     /// </summary>
     /// <param name="party">The party the authenticated user is performing client administration on behalf of</param>
     /// <param name="request">Request Dto</param>
+    /// <returns><seealso cref="ExtConnection"/>List of connections</returns>
     [HttpPost]
     [Authorize(Policy = AuthzConstants.POLICY_CLIENTDELEGATION_WRITE)]
     public async Task<ActionResult> PostClientDelegation([FromQuery] Guid party, [FromBody] CreateSystemDelegationRequestDto request)
@@ -56,13 +57,14 @@ public async Task<ActionResult> PostClientDelegation([FromQuery] Guid party, [Fr
         }
 
         var delegations = await delegationService.CreateClientDelegation(request, userId, party);
-        var result = new List<ExtDelegation>();
+        var result = new List<ExtConnection>();
 
         foreach (var delegation in delegations)
         {
-            result.Add(await delegationRepository.GetExtended(delegation.Id));
+            result.Add(await connectionRepository.GetExtended(delegation.Id));
         }
 
+        // Remark: Kan ikke garantere at det KUN er delegeringer som er opprettet i denne handlingen som blir returnert.
         return Ok(result);
     }
 
@@ -175,7 +177,7 @@ public async Task<ActionResult> DeleteClientAssignment([FromQuery] Guid party, [
     /// </summary>
     /// <param name="party">The party the authenticated user is performing client administration on behalf of</param>
     /// <param name="systemUser">The system user the authenticated user is delegating access to</param>
-    /// <returns></returns>
+    /// <returns><seealso cref="ExtConnection"/>List of connections</returns>
     [HttpGet]
     [Authorize(Policy = AuthzConstants.POLICY_CLIENTDELEGATION_READ)]
     public async Task<ActionResult> GetClientDelegations([FromQuery] Guid party, [FromQuery] Guid systemUser)
@@ -186,10 +188,10 @@ public async Task<ActionResult> GetClientDelegations([FromQuery] Guid party, [Fr
             return Unauthorized();
         }
 
-        var filter = delegationRepository.CreateFilterBuilder();
-        filter.Equal(t => t.ToId, systemUser);
-        filter.Equal(t => t.FacilitatorId, party);
-        var res = await delegationRepository.GetExtended(filter);
+        var f = connectionRepository.CreateFilterBuilder();
+        f.Equal(t => t.ToId, systemUser);
+        f.Equal(t => t.FacilitatorId, party);
+        var res = await connectionRepository.GetExtended(f);
 
         return Ok(res);
     }

src/apps/Altinn.AccessManagement/src/Altinn.AccessMgmt.Persistence/Services/DelegationService.cs

@@ -186,21 +186,21 @@ [ ] Check i Resource is Delegable
     public async Task<IEnumerable<Delegation>> CreateClientDelegation(CreateSystemDelegationRequestDto request, Guid userId, Guid facilitatorPartyId)
     {
         // Find user : Fredrik
-        var user = (await entityRepository.Get(userId)) ?? throw new Exception(string.Format("Party not found '{0}'", userId));
+        var user = (await entityRepository.Get(userId)) ?? throw new Exception(string.Format("Party not found '{0}' for user", userId));
 
         // Find Facilitator : Regnskapsfolk
-        var facilitator = (await entityRepository.Get(facilitatorPartyId)) ?? throw new Exception(string.Format("Party not found '{0}'", facilitatorPartyId));
+        var facilitator = (await entityRepository.Get(facilitatorPartyId)) ?? throw new Exception(string.Format("Party not found '{0}' for facilitator", facilitatorPartyId));
 
         // Find admin role : Tilgangstyrer eller KlientAdmin
 
         // Find Agent Role : AGENT
         var agentRole = await GetRole(request.AgentRole) ?? throw new Exception(string.Format("Role not found '{0}'", request.AgentRole));
 
         // Find Agent
-        var agent = await GetOrCreateEntity(request.AgentId, request.AgentName, request.AgentId.ToString(), "Systembruker", "System") ?? throw new Exception(string.Format("Could not find or create '{0}'", request.AgentId));
+        var agent = await GetOrCreateEntity(request.AgentId, request.AgentName, request.AgentId.ToString(), "Systembruker", "System") ?? throw new Exception(string.Format("Could not find or create party '{0}' for agent", request.AgentId));
 
         // Find ClientId : Bakeriet
-        var client = (await entityRepository.Get(request.ClientId)) ?? throw new Exception(string.Format("Party not found '{0}'", request.ClientId));
+        var client = (await entityRepository.Get(request.ClientId)) ?? throw new Exception(string.Format("Party not found '{0}' for client", request.ClientId));
 
         // Find or Create Agent Assignment : Regnskapsfolk - AGENT - SystemBruker01
         var agentAssignment = await GetOrCreateAssignment(facilitator, agent, agentRole) ?? throw new Exception(string.Format("Could not find or create assignment '{0}' - {1} - {2}", facilitator.Name, agentRole.Code, agent.Name));