From 8ce58881f20ca3c3e250317d516b92204a9327cb Mon Sep 17 00:00:00 2001
From: Andreas Isnes <andreas.isnes@gmail.com>
Date: Wed, 17 Jul 2024 10:39:04 +0200
Subject: [PATCH] remove unused locals

---
 infrastructure/modules/dns/outputs.tf    | 5 ++++-
 infrastructure/modules/key_vault/main.tf | 6 ------
 infrastructure/shared/main.tf            | 2 +-
 3 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/infrastructure/modules/dns/outputs.tf b/infrastructure/modules/dns/outputs.tf
index 071fb141..923b93d5 100644
--- a/infrastructure/modules/dns/outputs.tf
+++ b/infrastructure/modules/dns/outputs.tf
@@ -3,5 +3,8 @@ output "zones" {
     {
       id   = azurerm_private_dns_zone.dns[key].id
       name = value
-  } }
+    }
+  }
+
+  description = "Map of all private link DNS zones. The keys are the resource type name. e.g service_bus. Value contains the fields 'id' which is the ARM reference and name the domain"
 }
diff --git a/infrastructure/modules/key_vault/main.tf b/infrastructure/modules/key_vault/main.tf
index 9346452f..a52ac473 100644
--- a/infrastructure/modules/key_vault/main.tf
+++ b/infrastructure/modules/key_vault/main.tf
@@ -1,9 +1,3 @@
-locals {
-
-}
-
-data "azurerm_client_config" "current" {}
-
 # https://learn.microsoft.com/en-us/azure/role-based-access-control/built-in-roles#security
 data "azurerm_role_definition" "key_vault_administrator" {
   role_definition_id = "00482a5a-887f-4fb3-b363-3b7fe8e74483"
diff --git a/infrastructure/shared/main.tf b/infrastructure/shared/main.tf
index a3038b86..a0fabde5 100644
--- a/infrastructure/shared/main.tf
+++ b/infrastructure/shared/main.tf
@@ -67,7 +67,7 @@ module "key_vault" {
   resource_group_name = azurerm_resource_group.authorization.name
   metadata            = local.metadata
 
-  ###! Changing these deletes and creates new one(s)
+  ###! Changing key or value deletes and creates a new one!
   encryption_keys = {
     service_bus = "ServiceBusEncryptionKey"
   }