Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the test coverage of message box search and search in general (Follow up from Post-mortem) #451

Open
1 task
SandGrainOne opened this issue Jul 9, 2024 · 1 comment
Labels
kind/chore Typical issues like patching and deployment. status/draft Status: When you create an issue before you have enough info to properly describe the issue.

Comments

@SandGrainOne
Copy link
Member

SandGrainOne commented Jul 9, 2024

Description

Back in July 2023 Storage were updated to use PostgreSQL instead of CosmosDB. During that work we had a bug that managed to get all the way out to TT02. One of the follow up points from the Post-mortem were to improve the test coverage.

This issue includes an analysis of the existing tests to see if there are things that can be improved. A lot has already been changed in a year.

The Post-mortem is documented in a private repository. (There should be a link below for anyone with access).

Introduced an error in serialization of a date field made it so that the date became invalid.

The example url from the incident:
https://platform.tt02.altinn.no/storage/api/v1/instances?appId=skd/mva-melding-innsending-v1&size=1000&lastChanged=gt:2022-07-05T12:24:29.473059143&instanceOwner.partyId=51486565&excludeConfirmedBy=skd&status.isArchived=false&status.isSoftDeleted=false&status.isHardDeleted=false

  • appId=skd/mva-melding-innsending-v1
  • size=1000
  • lastChanged=gt:2022-07-05T12:24:29.473059143
  • instanceOwner.partyId=51486565
  • excludeConfirmedBy=skd
  • status.isArchived=false
  • status.isSoftDeleted=false
  • status.isHardDeleted=false

Additional Information

Another related issue is #27. Maybe that issue can follow up both points. Test coverage would need to be reviewed with new changes anyway.

Tasks

  • Add test cases where the search filters include filtering based on date.

Acceptance Criterias

No response

@SandGrainOne SandGrainOne added status/draft Status: When you create an issue before you have enough info to properly describe the issue. kind/chore Typical issues like patching and deployment. labels Jul 9, 2024
@olebhansen
Copy link

@SandGrainOne : Investigate post-mortem to identify relevant testcases to add

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Typical issues like patching and deployment. status/draft Status: When you create an issue before you have enough info to properly describe the issue.
Projects
None yet
Development

No branches or pull requests

2 participants