-
Notifications
You must be signed in to change notification settings - Fork 50
feat: change signing data elements ordering #2408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughDocumentation for SigningDocumentList updated in English and Norwegian Bokmål to describe table row sorting by dataTypesToSign order from process.bpmn, then by document creation date. No code or API changes. Please check documentation in en-US, nb-NO, and nn-NO. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used📓 Path-based instructions (1)content/**/*⚙️ CodeRabbit configuration file
Files:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
content/altinn-studio/v8/reference/ux/components/SigningDocumentList/_index.en.md(1 hunks)content/altinn-studio/v8/reference/ux/components/SigningDocumentList/_index.nb.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
content/**/*
⚙️ CodeRabbit configuration file
Check for links, markdown formatting, headings, grammar, and spelling in multiple languages (en-US, nb-NO, nn-NO).
Files:
content/altinn-studio/v8/reference/ux/components/SigningDocumentList/_index.en.mdcontent/altinn-studio/v8/reference/ux/components/SigningDocumentList/_index.nb.md
**/*.nb.md
⚙️ CodeRabbit configuration file
Check for Norwegian Bokmål (nb-NO) grammar and spelling with extra care. Pay special attention to specialized terminology and Norwegian-specific words.
Files:
content/altinn-studio/v8/reference/ux/components/SigningDocumentList/_index.nb.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
content/altinn-studio/v8/reference/ux/components/SigningDocumentList/_index.nb.md (1)
75-75: Juster flertallsformen for «opprettelsesdato».Bytt ut «dokumentenes opprettelsesdato» med «dokumentenes opprettelsesdatoer» (eller «hver enkelt dokuments opprettelsesdato») slik at flertall samsvarer gjennom setningen.
⛔ Skipped due to learnings
Learnt from: mSunberg PR: Altinn/altinn-studio-docs#0 File: :0-0 Timestamp: 2025-04-04T08:22:36.805Z Learning: When reviewing Norwegian content (files with .nb.md or .nn.md extensions), carefully check for spelling and grammar issues, particularly watching for changes to specialized terminology like "Digitaliseringsrundskrivet" and Norwegian-specific words.
content/altinn-studio/v8/reference/ux/components/SigningDocumentList/_index.en.md
Outdated
Show resolved
Hide resolved
Add documentation for the changes requested in Altinn/app-frontend-react#3367
e336a06 to
f39c201
Compare
Add documentation for the changes requested in Altinn/app-frontend-react#3367, implemented in Altinn/app-lib-dotnet#1511 and Altinn/app-frontend-react#3775.
Summary by CodeRabbit