doc: convention-based use of application texts #2485
Conversation
WalkthroughAdds a new Python project configuration file and extensive documentation (English and Norwegian Bokmål) describing a convention-based key format and lookup order for resolving localized application texts. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant App as Client App
participant Lookup as TextLookup Service
participant Store as Key Store (nb/nn/en)
Note over App,Lookup: Resolve dialog text for content_type/task/state
App->>Lookup: request(key: dp.{content_type}.{task}.{state}, locale)
alt Tier 1 — content_type.task.state (most specific)
Lookup->>Store: query dp.content_type.task.state (locale)
Store-->>Lookup: found? yes/no
else Tier 2 — content_type.task
Lookup->>Store: query dp.content_type.task (locale)
Store-->>Lookup: found? yes/no
else Tier 3 — content_type.state
Lookup->>Store: query dp.content_type.state (locale)
Store-->>Lookup: found? yes/no
else Tier 4 — content_type (fallback)
Lookup->>Store: query dp.content_type (locale)
Store-->>Lookup: result (or not found)
end
alt Found
Lookup-->>App: return localized text (first-match wins)
else Not found
Lookup-->>App: return default fallback (title/summary/action labels per locale)
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
content/dialogporten/pyproject.toml(1 hunks)content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.en.md(2 hunks)content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.nb.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
content/**/*
⚙️ CodeRabbit configuration file
Check for links, markdown formatting, headings, grammar, and spelling in multiple languages (en-US, nb-NO, nn-NO).
Files:
content/dialogporten/pyproject.tomlcontent/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.en.mdcontent/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.nb.md
**/*.nb.md
⚙️ CodeRabbit configuration file
Check for Norwegian Bokmål (nb-NO) grammar and spelling with extra care. Pay special attention to specialized terminology and Norwegian-specific words.
Files:
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.nb.md
🧠 Learnings (1)
📚 Learning: 2025-10-27T07:48:11.643Z
Learnt from: lvbachmann
PR: Altinn/altinn-studio-docs#2477
File: content/authorization/migration/servicemigrationplan/_index.nb.md:4-4
Timestamp: 2025-10-27T07:48:11.643Z
Learning: In content/authorization/migration/servicemigrationplan/_index.nb.md (Norwegian Bokmål), the use of "Altinn II" in the description and "Altinn 2" in the document body is intentional and reflects actual naming conventions. This terminology difference should not be flagged as an inconsistency.
Applied to files:
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.en.mdcontent/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.nb.md
🪛 LanguageTool
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.en.md
[grammar] ~108-~108: Ensure spelling is correct
Context: ..., ventar på endeleg stadfesting. Du kan opne dialogen for å sjå ei førebels kvitteri...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~109-~109: Ensure spelling is correct
Context: ...nsendinga er stadfesta motteken. Du kan opne dialogen for å sjå di kvittering. ...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[style] ~112-~112: The word ‘til’ with one ‘l’ is informal. Consider replacing it.
Context: ... | Innsendingen må bekreftes for å gå til neste steg. ...
(TIL)
[style] ~112-~112: The word ‘til’ with one ‘l’ is informal. Consider replacing it.
Context: ... | Innsendinga må stadfestast for å gå til neste steg. ...
(TIL)
[style] ~113-~113: The word ‘til’ with one ‘l’ is informal. Consider replacing it.
Context: ... | Innsendingen må signeres for å gå til neste steg. ...
(TIL)
[style] ~113-~113: The word ‘til’ with one ‘l’ is informal. Consider replacing it.
Context: ... | Innsendinga må signerast for å gå til neste steg. ...
(TIL)
[style] ~114-~114: The word ‘til’ with one ‘l’ is informal. Consider replacing it.
Context: ... og trenger flere opplysninger for å gå til neste steg. ...
(TIL)
[style] ~114-~114: The word ‘til’ with one ‘l’ is informal. Consider replacing it.
Context: ...d og treng fleire opplysningar for å gå til neste steg. ...
(TIL)
[style] ~114-~114: Consider using a more formal alternative.
Context: ... submission is in progress and requires more information to proceed to the next step. ...
(MORE_INFO)
[grammar] ~115-~115: Ensure spelling is correct
Context: ... | Innsendinga er klar til å fyllast ut. ...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[style] ~115-~115: The word ‘til’ with one ‘l’ is informal. Consider replacing it.
Context: ... | Innsendinga er klar til å fyllast ut. ...
(TIL)
[grammar] ~115-~115: Ensure spelling is correct
Context: ... | Innsendinga er klar til å fyllast ut. ...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[style] ~122-~122: The word ‘til’ with one ‘l’ is informal. Consider replacing it.
Context: ...Active** (any non-archived status) | Gå til skjemautfylling | Gå til skjemautfyllin...
(TIL)
[style] ~122-~122: The word ‘til’ with one ‘l’ is informal. Consider replacing it.
Context: ...d status) | Gå til skjemautfylling | Gå til skjemautfylling | Go to form completion...
(TIL)
🪛 markdownlint-cli2 (0.18.1)
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.en.md
22-22: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
59-59: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
60-60: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
61-61: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
62-62: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
63-63: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
66-66: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
67-67: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
70-70: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
71-71: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
72-72: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
73-73: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
74-74: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (4)
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.en.md (1)
95-135: Verify Nynorsk translations and "til" usage style in tables.LanguageTool has flagged several style and spelling concerns in the default fallback value tables, particularly in the Nynorsk (nn) column. The word "til" (with one 'l') is flagged as informal; the formal alternative is "til å". Additionally, some Nynorsk spelling variations have been flagged.
Review the Nynorsk text (nn) column entries to confirm:
- Spelling accuracy (e.g., "opne" vs. standard forms, "motteken" vs. "mottatt", "fyllast" forms)
- Whether the "til" usage is acceptable in the context of these standard text defaults, or whether "til å" should be used
Given the formal nature of default system messages, consider whether more formal phrasing is warranted. However, this may be intentional stylistic consistency with the broader documentation or Altinn conventions.
Could you verify that the Nynorsk (nn) translations in the summary and action label tables (lines 106–135) follow current Nynorsk orthography and style conventions? Specifically:
- Lines 108–118: Verify spelling in Nynorsk summary text (e.g., "opne", "motteken", "fyllast")
- Consider whether "til å" is more appropriate than "til" for formal default messages
As per coding guidelines, Norwegian Bokmål and Nynorsk require extra care for grammar, spelling, and specialized terminology.
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.nb.md (2)
109-138: Verify Bokmål grammar/terminology and Nynorsk accuracy in tables.The tables contain Norwegian Bokmål translations alongside Nynorsk and English. Verify that:
- Bokmål (nb) accuracy: Review the terminology and phrasing for accuracy and consistency with Altinn conventions (e.g., terms like "maskinelt kontrollert", "formidlet", "stadfesting", etc.)
- Nynorsk (nn) accuracy: Similar to the English version, LanguageTool has flagged Nynorsk spelling variations and informal "til" usage. Confirm these follow current Nynorsk orthography and are consistent with formal system text conventions.
Pay particular attention to:
- Lines 111–118: Spelling of Nynorsk forms (e.g., "opne", "motteken", "fyllast")
- "til" vs. "til å" usage across both Bokmål and Nynorsk columns
- Terminology consistency (e.g., "innsending" vs. "innsendt", "skjema" vs. "skjemautfylling")
As per coding guidelines, Norwegian Bokmål and Nynorsk require extra attention to grammar, spelling, and specialized terminology.
Please verify the Bokmål and Nynorsk translations in the summary, action label, and implementation tables for orthographic accuracy and terminology consistency with Altinn standards.
82-82: Fix missing space in example key.Line 82 has a missing space after the backtick-enclosed key, mirroring the same issue in the English version.
Apply this diff:
-* `dp.primaryactionlabel` Generell primær handlingstekst +* `dp.primaryactionlabel` Generell primær handlingstekstWait, let me check line 82 again - it shows "*
dp.primaryactionlabelGenerell primær handlingstekst" which appears to already have the space. Let me re-examine...Actually, I need to look at the exact annotated code provided. Line 82 in the nb file shows:
*dp.primaryactionlabelGenerell primær handlingstekstThis appears correct (space is present). Let me check if there's an issue I'm missing.
Looking at _index.en.md line 80:
*dp.primaryactionlabelGeneral primary action text- YES, missing space here.
Looking at _index.nb.md line 82:*dp.primaryactionlabelGenerell primær handlingstekst- appears to have space.So the English file has the error, but the Norwegian file may already be correct. Let me skip this for the Norwegian file.
Likely an incorrect or invalid review comment.
content/dialogporten/pyproject.toml (1)
1-6: Version specification is current and well-configured.The
google-generativeai>=0.8.5specification is appropriate—the latest stable version is 0.8.5 (uploaded Apr 17, 2025). The>=constraint allows for patch and future minor version updates, which is the standard practice. The Python 3.13 requirement is appropriately forward-looking for an Oct 2025 project timeline.
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.en.md
Show resolved
Hide resolved
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.en.md
Outdated
Show resolved
Hide resolved
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.nb.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.nb.md (1)
57-73: Fix unordered list indentation to use 2 spaces (duplicate of previous review).Same markdown linting issue as flagged in the previous review: nested bullet items should use 2-space indentation, not 4. This was previously noted but remains unfixed.
Apply this diff to correct the indentation:
**Komponenter:** -- **content_type** (obligatorisk): En av: - - `title` - Dialogtittel - - `summary` - Dialogsammendrag/beskrivelse - - `primaryactionlabel` - Primær handlingsknapptekst - - `secondaryactionlabel` - Sekundær handlingsknapptekst - - `tertiaryactionlabel` - Tertiær handlingsknapptekst +- **content_type** (obligatorisk): En av: + - `title` - Dialogtittel + - `summary` - Dialogsammendrag/beskrivelse + - `primaryactionlabel` - Primær handlingsknapptekst + - `secondaryactionlabel` - Sekundær handlingsknapptekst + - `tertiaryactionlabel` - Tertiær handlingsknapptekst -- **task** (valgfritt): Enten: - - Et spesifikt oppgavenavn (alfanumerisk med interne bindestreker eller understreker) - - `_any_` for wildcard-matching +- **task** (valgfritt): Enten: + - Et spesifikt oppgavenavn (alfanumerisk med interne bindestreker eller understreker) + - `_any_` for wildcard-matching -- **state** (valgfritt): Instansstatusen, for eksempel: - - `archivedunconfirmed`, `archivedconfirmed` - - `rejected` - - `awaitingserviceownerfeedback`, `awaitingconfirmation` - - `awaitingsignature`, `awaitingadditionaluserinput` - - `awaitinginitialuserinput`, `awaitinginitialuserinputfromprefill` +- **state** (valgfritt): Instansstatusen, for eksempel: + - `archivedunconfirmed`, `archivedconfirmed` + - `rejected` + - `awaitingserviceownerfeedback`, `awaitingconfirmation` + - `awaitingsignature`, `awaitingadditionaluserinput` + - `awaitinginitialuserinput`, `awaitinginitialuserinputfromprefill`
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.nb.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.nb.md
⚙️ CodeRabbit configuration file
Check for Norwegian Bokmål (nb-NO) grammar and spelling with extra care. Pay special attention to specialized terminology and Norwegian-specific words.
Files:
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.nb.md
content/**/*
⚙️ CodeRabbit configuration file
Check for links, markdown formatting, headings, grammar, and spelling in multiple languages (en-US, nb-NO, nn-NO).
Files:
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.nb.md
🧠 Learnings (1)
📚 Learning: 2025-10-27T07:48:11.643Z
Learnt from: lvbachmann
PR: Altinn/altinn-studio-docs#2477
File: content/authorization/migration/servicemigrationplan/_index.nb.md:4-4
Timestamp: 2025-10-27T07:48:11.643Z
Learning: In content/authorization/migration/servicemigrationplan/_index.nb.md (Norwegian Bokmål), the use of "Altinn II" in the description and "Altinn 2" in the document body is intentional and reflects actual naming conventions. This terminology difference should not be flagged as an inconsistency.
Applied to files:
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.nb.md
🪛 markdownlint-cli2 (0.18.1)
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.nb.md
58-58: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
59-59: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
60-60: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
61-61: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
62-62: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
65-65: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
66-66: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
69-69: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
70-70: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
71-71: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
72-72: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
73-73: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (5)
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.nb.md (5)
24-24: Link formatting looks good.The Hugo shortcode syntax is correct for the reference link.
34-54: Section structure and language verified.The new section headers, introduction, and key lookup order explanation are well-formatted and use correct Norwegian Bokmål.
75-95: Examples section is well-formatted and clear.The examples are properly formatted with correct code syntax highlighting and clear Norwegian descriptions.
102-137: Fallback values tables are properly formatted and comprehensive.The tables provide clear multilingual fallback values with correct markdown formatting and appropriate Norwegian translations.
138-144: Implementation notes are clear and properly formatted.The notes correctly document key technical details with clear Norwegian explanations.
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.nb.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.en.md (1)
64-65: Fix unordered list indentation to use 2 spaces.Lines 64-65 use 4-space indentation inconsistently with the rest of the nested list structure (lines 57-62 and 68-72 correctly use 2 spaces).
Apply this diff to correct the indentation:
- **task** (optional): Either: - - A specific task name (alphanumeric with internal dashes or underscores) - - `_any_` for wildcard matching + - A specific task name (alphanumeric with internal dashes or underscores) + - `_any_` for wildcard matching
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
content/dialogporten/pyproject.toml(1 hunks)content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.en.md(2 hunks)content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.nb.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
content/**/*
⚙️ CodeRabbit configuration file
Check for links, markdown formatting, headings, grammar, and spelling in multiple languages (en-US, nb-NO, nn-NO).
Files:
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.en.mdcontent/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.nb.mdcontent/dialogporten/pyproject.toml
**/*.nb.md
⚙️ CodeRabbit configuration file
Check for Norwegian Bokmål (nb-NO) grammar and spelling with extra care. Pay special attention to specialized terminology and Norwegian-specific words.
Files:
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.nb.md
🧠 Learnings (1)
📚 Learning: 2025-10-27T07:48:11.643Z
Learnt from: lvbachmann
PR: Altinn/altinn-studio-docs#2477
File: content/authorization/migration/servicemigrationplan/_index.nb.md:4-4
Timestamp: 2025-10-27T07:48:11.643Z
Learning: In content/authorization/migration/servicemigrationplan/_index.nb.md (Norwegian Bokmål), the use of "Altinn II" in the description and "Altinn 2" in the document body is intentional and reflects actual naming conventions. This terminology difference should not be flagged as an inconsistency.
Applied to files:
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.en.mdcontent/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.nb.md
🪛 LanguageTool
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.en.md
[grammar] ~108-~108: Ensure spelling is correct
Context: ..., ventar på endeleg stadfesting. Du kan opne dialogen for å sjå ei førebels kvitteri...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~109-~109: Ensure spelling is correct
Context: ...nsendinga er stadfesta motteken. Du kan opne dialogen for å sjå di kvittering. ...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[style] ~112-~112: The word ‘til’ with one ‘l’ is informal. Consider replacing it.
Context: ... | Innsendingen må bekreftes for å gå til neste steg. ...
(TIL)
[style] ~112-~112: The word ‘til’ with one ‘l’ is informal. Consider replacing it.
Context: ... | Innsendinga må stadfestast for å gå til neste steg. ...
(TIL)
[style] ~113-~113: The word ‘til’ with one ‘l’ is informal. Consider replacing it.
Context: ... | Innsendingen må signeres for å gå til neste steg. ...
(TIL)
[style] ~113-~113: The word ‘til’ with one ‘l’ is informal. Consider replacing it.
Context: ... | Innsendinga må signerast for å gå til neste steg. ...
(TIL)
[style] ~114-~114: The word ‘til’ with one ‘l’ is informal. Consider replacing it.
Context: ... og trenger flere opplysninger for å gå til neste steg. ...
(TIL)
[style] ~114-~114: The word ‘til’ with one ‘l’ is informal. Consider replacing it.
Context: ...d og treng fleire opplysningar for å gå til neste steg. ...
(TIL)
[style] ~114-~114: Consider using a more formal alternative.
Context: ... submission is in progress and requires more information to proceed to the next step. ...
(MORE_INFO)
[grammar] ~115-~115: Ensure spelling is correct
Context: ... | Innsendinga er klar til å fyllast ut. ...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[style] ~115-~115: The word ‘til’ with one ‘l’ is informal. Consider replacing it.
Context: ... | Innsendinga er klar til å fyllast ut. ...
(TIL)
[grammar] ~115-~115: Ensure spelling is correct
Context: ... | Innsendinga er klar til å fyllast ut. ...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[style] ~122-~122: The word ‘til’ with one ‘l’ is informal. Consider replacing it.
Context: ...Active** (any non-archived status) | Gå til skjemautfylling | Gå til skjemautfyllin...
(TIL)
[style] ~122-~122: The word ‘til’ with one ‘l’ is informal. Consider replacing it.
Context: ...d status) | Gå til skjemautfylling | Gå til skjemautfylling | Go to form completion...
(TIL)
🪛 markdownlint-cli2 (0.18.1)
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.en.md
22-22: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
64-64: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
65-65: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (4)
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.en.md (2)
34-142: I'll verify the documentation across all required languages and check for consistency.Now let me check for the Norwegian language documentation files in the repository structure:
Let me search within the repository for the Norwegian language documentation files and any related implementation details:Based on my investigation, I was unable to locate specific implementation details for task name validation constraints in the publicly available Altinn Dialogporten repositories or documentation. The web search did not return definitive information confirming or contradicting the documented task name format constraints (alphanumeric with internal dashes/underscores, must start/end with alphanumeric characters).
Given that:
- This is documentation for a new feature
- The content is well-structured and comprehensive
- No contradictory information was found in external sources
- The task name constraint appears reasonable and follows common naming conventions
- The original review comment requests verification rather than identifies specific errors
Verify the documentation accuracy of task name constraints across all supported language versions (English, Norwegian Bokmål, Norwegian Nynorsk).
The multilingual tables and conventions documentation are well-presented. However, ensure:
- Norwegian language versions exist (_index.nb.md, _index.nn.md) with accurate translations
- Task name constraint details (line 140: "alphanumeric with internal dashes or underscores, must start and end with alphanumeric characters") match the actual system implementation
- Default fallback values in all language tables are identical across translations
24-24: Link target is accessible and resolves correctly.The Hugo link reference
../../../reference/front-end/altinn-appssuccessfully resolves to a valid documentation page. The target directory exists with content in both English (en-US) and Norwegian Bokmål (nb-NO).Note: Norwegian Nynorsk (nn-NO) documentation variants are missing throughout the reference/front-end/ structure, including both the target (altinn-apps) and source (integrating-altinn-apps) directories. This appears to be a codebase-wide pattern rather than a link-specific issue, but consider whether nn-NO documentation completeness is required per your documentation standards.
content/dialogporten/user-guides/service-owners/integrating-altinn-apps/_index.nb.md (2)
34-143: Content terminology and multilingual structure verified—no issues identified.Technical terminology across the section is consistent with established patterns in the documentation (e.g., "oppgave" for task, "innebygde standardverdier" for built-in defaults, "applikasjonstekster" for application texts). Multilingual content is properly structured with Bokmål (nb), Nynorsk (nn), and English (en) included in the reference tables. No spelling or grammar errors detected.
24-24: Link target is accessible, but multilingual coverage is incomplete.The Hugo link reference
../../../reference/front-end/altinn-appscorrectly resolves to a valid documentation page with content in English and Norwegian Bokmål. However, the target page lacks a Norwegian Nynorsk (_index.nn.md) variant, which is required per the coding guidelines for content files to support all specified languages (en-US, nb-NO, nn-NO).
1 participant
Summary by CodeRabbit