Update SMS send window guidance #2555
Conversation
|
Note
|
| Cohort / File(s) | Change Summary |
|---|---|
Notification delivery pages content/notifications/what-do-you-get/_index.en.md, content/notifications/what-do-you-get/_index.nb.md |
Removed statement that SMS are sent only 09:00–17:00 (Norway). Added smsSettings.sendingTimePolicy with options Anytime (default, 24/7) and Daytime (08:00–21:00 Europe/Oslo). Clarified that scheduled notifications are delivered at the chosen time interpreted in Europe/Oslo, even outside office hours, and that orders may be created or updated at any time. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
- Documentation-only edits; no API or code changes.
- Files to spot-check: the two modified markdown pages for accurate timezone phrasing and consistent terminology (
AnytimevsDaytime, Europe/Oslo).
Poem
📬 No more queues from nine to five,
Alerts live round-the-clock and thrive.
Oslo time now sets the beat,
Schedules land right on the seat. ✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title accurately summarizes the main change: updating documentation about SMS notification sending windows from fixed office hours to 24/7 flexibility. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✨ Finishing touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
- Commit unit tests in branch
docs/update-sms-send-window
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
content/notifications/what-do-you-get/_index.en.md(1 hunks)content/notifications/what-do-you-get/_index.nb.md(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- content/notifications/what-do-you-get/_index.nb.md
🧰 Additional context used
📓 Path-based instructions (1)
content/**/*
⚙️ CodeRabbit configuration file
Check for links, markdown formatting, headings, grammar, and spelling in multiple languages (en-US, nb-NO, nn-NO).
Files:
content/notifications/what-do-you-get/_index.en.md
🧠 Learnings (2)
📚 Learning: 2025-08-13T07:18:32.545Z
Learnt from: Ahmed-Ghanam
Repo: Altinn/altinn-studio-docs PR: 2308
File: static/swagger/altinn-notifications-v1.json:1716-1760
Timestamp: 2025-08-13T07:18:32.545Z
Learning: The Altinn Notifications API uses external libraries for mobile number validation instead of OpenAPI regex patterns. They prefer application-level validation over schema-level constraints for phone numbers.
Applied to files:
content/notifications/what-do-you-get/_index.en.md
📚 Learning: 2025-08-13T07:18:14.926Z
Learnt from: Ahmed-Ghanam
Repo: Altinn/altinn-studio-docs PR: 2308
File: static/swagger/altinn-notifications-v1.json:1475-1483
Timestamp: 2025-08-13T07:18:14.926Z
Learning: The Altinn Notifications API uses server-side validators (like NotificationReminderValidator) to enforce business rules rather than relying solely on OpenAPI schema constraints. They prefer automated schema generation over manual OpenAPI specification changes to keep the schema aligned with actual validation logic.
Applied to files:
content/notifications/what-do-you-get/_index.en.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
content/notifications/what-do-you-get/_index.en.md (1)
37-42: Well-addressed previous feedback on sendingTimePolicy clarification.The updated section clearly documents the configurable send window with both the
Anytime(24/7 default) andDaytime(08:00-21:00 Europe/Oslo) options, directly addressing the previous review comment to clarify this setting. The markdown formatting is clean, grammar is correct, and the terminology is consistent. This successfully communicates the new 24/7 capability alongside the optional daytime policy.However, the coding guidelines require checking documentation in English (en-US), Norwegian Bokmål (nb-NO), and Norwegian Nynorsk (nn-NO). The PR summary indicates that parallel changes have been made to
_index.nb.md, but only the English version is provided for review. Please verify that the Norwegian versions have been updated consistently with equivalent clarity and terminology.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
| - SMS notifications are sent daily between **9 AM and 5 PM (Norway time)**. | ||
| - Notifications scheduled outside this timeframe are sent at **9 AM the following day**. | ||
| - Notification orders can be placed at any time. | ||
| - SMS notifications can be sent **around the clock, every day of the year**. |
There was a problem hiding this comment.
Jeg tror vi burde presisere at sendevindu kan velges mellom Anytime og Daytime med sendingTimePolicy i smsSettings
There was a problem hiding this comment.
Takk Sigrid, jeg endret litt i teksten nå 💯
2 participants
This pull request updates the documentation for Altinn SMS notifications to clarify that SMS messages can now be sent at any time, not just during office hours. It also specifies that scheduled notifications will be delivered at the selected time, even outside of traditional work hours, and that orders can be placed or updated at any time.
Documentation updates:
_index.en.md) to state that SMS notifications can be sent 24/7, scheduled notifications are delivered at the selected time (Europe/Oslo time zone), and orders can be placed or updated at any time._index.nb.md) with the same changes to reflect 24/7 sending, scheduled delivery at the chosen time, and flexibility in placing or updating orders.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.