Skip to content

Conversation

@HauklandJ
Copy link
Contributor

@HauklandJ HauklandJ commented Nov 12, 2025

Description

Make parallellism configurable to make it easier to change the traffic volume for the operations we do in parallell

Verification

  • Related issues are connected (if applicable)
  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Konrad-Simso and others added 30 commits November 10, 2025 10:14
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 12, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/configure-parallellism

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added skip-releasenotes Issues that do not make sense to list in our release notes backend solution/studio/designer labels Nov 12, 2025
@github-actions github-actions bot added the quality/testing Tests that are missing, needs to be created or could be improved. label Nov 12, 2025
Copy link
Member

@ivarne ivarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm not sure I understand the rationale here.

If I for some reason wanted to change one of these parameters before

  • Find the code that does the operation and change the value
  • Commit, push and deploy

After this change:

  • Find the code that does the operation and see what the config variable is called
    • Search the code repo, deployment scripts, key vaults and environment variable configs to see where and how the config is used
  • Change the value in appsettings.json (or any other places where the config might be set)
  • Commit, push and deploy

Is it likely that the extra flexibility in configuration will actually be used?

@Konrad-Simso Konrad-Simso force-pushed the feat/update-org-library-endpoints branch from fb83105 to 21fb225 Compare November 13, 2025 12:45
@HauklandJ
Copy link
Contributor Author

@ivarne yeah, without a configmap it is not easier or faster to update the app. We also do not need different values for the different environments here.. So I am starting to regret this change. Glad I took it out as a feature branch to the feature branch rather than committing there directly.

@HauklandJ HauklandJ force-pushed the feat/update-org-library-endpoints branch from e10c313 to 019e482 Compare November 14, 2025 07:48
@HauklandJ HauklandJ force-pushed the feat/update-org-library-endpoints branch 2 times, most recently from 105aebc to 99c46c5 Compare November 25, 2025 14:51
Base automatically changed from feat/update-org-library-endpoints to main November 26, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants