-
Notifications
You must be signed in to change notification settings - Fork 86
feat: configure parallellism #16953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: configure parallellism #16953
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I'm not sure I understand the rationale here.
If I for some reason wanted to change one of these parameters before
- Find the code that does the operation and change the value
- Commit, push and deploy
After this change:
- Find the code that does the operation and see what the config variable is called
- Search the code repo, deployment scripts, key vaults and environment variable configs to see where and how the config is used
- Change the value in appsettings.json (or any other places where the config might be set)
- Commit, push and deploy
Is it likely that the extra flexibility in configuration will actually be used?
fb83105 to
21fb225
Compare
|
@ivarne yeah, without a configmap it is not easier or faster to update the app. We also do not need different values for the different environments here.. So I am starting to regret this change. Glad I took it out as a feature branch to the feature branch rather than committing there directly. |
e10c313 to
019e482
Compare
105aebc to
99c46c5
Compare
Description
Make parallellism configurable to make it easier to change the traffic volume for the operations we do in parallell
Verification