Improve internal analyzer regarding AppImplementationFactory
#3731
martinothamartest-and-analyze.yml
on: pull_request
Static code analysis
6m 13s
Annotations
10 warnings
|
Static code analysis:
src/Altinn.App.Core/AppImplementationFactory.cs#L36
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
|
|
Static code analysis:
src/Altinn.App.Internal.Analyzers/AppImplementationInjectionAnalyzer.cs#L303
Loop should be simplified by calling Select(parameter => parameter.Type)) (https://rules.sonarsource.com/csharp/RSPEC-3267)
|
|
Static code analysis:
src/Altinn.App.Internal.Analyzers/AppImplementationInjectionAnalyzer.cs#L314
Merge this if statement with the enclosing one. (https://rules.sonarsource.com/csharp/RSPEC-1066)
|
|
Static code analysis:
src/Altinn.App.Internal.Analyzers/AppImplementationInjectionAnalyzer.cs#L390
Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. (https://rules.sonarsource.com/csharp/RSPEC-3776)
|
|
Static code analysis:
src/Altinn.App.Internal.Analyzers/AppImplementationInjectionAnalyzer.cs#L343
Refactor this static local function to reduce its Cognitive Complexity from 19 to the 15 allowed. (https://rules.sonarsource.com/csharp/RSPEC-3776)
|
|
Static code analysis:
src/Altinn.App.Internal.Analyzers/AppImplementationInjectionAnalyzer.cs#L278
Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. (https://rules.sonarsource.com/csharp/RSPEC-3776)
|
|
Static code analysis:
src/Altinn.App.Internal.Analyzers/AppImplementationInjectionAnalyzer.cs#L189
Refactor this method to reduce its Cognitive Complexity from 30 to the 15 allowed. (https://rules.sonarsource.com/csharp/RSPEC-3776)
|
|
Static code analysis:
src/Altinn.App.Internal.Analyzers/AppImplementationInjectionAnalyzer.cs#L137
Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. (https://rules.sonarsource.com/csharp/RSPEC-3776)
|
|
Static code analysis:
src/Altinn.App.Internal.Analyzers/AppImplementationInjectionAnalyzer.cs#L9
Initialize all 'static fields' inline and remove the 'static constructor'. (https://rules.sonarsource.com/csharp/RSPEC-3963)
|
|
Static code analysis:
src/Altinn.App.Internal.Analyzers/AppImplementationInjectionAnalyzer.cs#L194
Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
|