Tests that make sure user provided implementations of interfaces have expected `ServiceLifetime`

[martinothamar]

Description

If an app developer registers an IInstanceProcessor as Transient, we should always instantiate it transiently (not accidentally make it a singleton by rooting it in some other service). Ideally we would not have to, but this is the least surprising behavior as app devs typically aren't concerned with what they put in constructors (ref the IHttpContextAccessor leak incident).

We should develop tests that ensure that all (commonly implemented) public interfaces live for the expected duration.

Additional Information

No response

Tasks

• Get a list of common user-implementable interfaces which we should develop lifetime tests for
• Implement tests

Acceptance Criterias

• When IInstantiationProcessor services are registrered as Transient, they are instantiated with each invocation of IProcessEventHandlerDelegator (or downstream services/deps) methods
• The above criteria should be true for any other user implemented interface

[martinothamar]

A list of interfaces

eFormidling:

• IEFormidlingMetadata
• IEFormidlingReceivers

validation:

• IDataElementValidator
• IFormDataValidator
• IInstanceValidator
• IInstantiationValidator
• ITaskValidator
• IFileValidator
• IFileAnalyser

process:

• IProcessExclusiveGateway
• IProcessTaskAbandon
• IProcessTaskEnd
• IProcessTaskStart
• IProcessTask
• IServiceTask
• IUserAction
• IUserActionAuthorizer

events:

• IEventHandler
• IEventSecretCodeProvider

data:

• IInstantiationProcessor
• IDataProcessor
• IExternalApiClient

payment:

• IOrderDetailsCalculator
• IPaymentProcessor

options (?):

• IInstanceAppOptionsProvider
• IAppOptionsProvider
• IAppOptionsFileHandler

datalist (?):

• IDataListProvider
• IInstanceDataListProvider

misc:

• IPageOrder
• IPdfFormatter
• IAppEvents
• IX509CertificateProvider

[martinothamar]

2 more things I'd like to do:

• Analyzer for constructor use of IHttpContextAccessor: Roslyn analyzer setup included in Altinn.App.Core, analyzer for IHttpContextAccessor.HttpContext usage #651
• Internal analyzer for usage of AppImplementationFactory in our constructors (Improve internal analyzer regarding AppImplementationFactory #1234)