Prepare for running apps and localtest with test containers for integration testing (#136)

* Set ASPNETCORE_URLS=http://*:5101/ in dockerfile

* Add proxy middleware so that localtest can be used without nginx "loadbalancer"

* Use Request.Host instead of env config for openId-configuration

* Improve logging in decicion controller

* Use Yarp proxy instead of custom proxy

* Add Health checks

* Use ILocalApp for all access to applicationmetadata

Author: ivarne

Dockerfile

@@ -8,12 +8,17 @@ COPY ./src .
 RUN dotnet publish LocalTest.csproj -c Release -o /app_output
 
 FROM mcr.microsoft.com/dotnet/aspnet:8.0-alpine@sha256:0389d5b7d60f75ebbeec3bfffd2ad0a06d234e7b998231a5a86abf5e919a7d01 AS final
+ENV ASPNETCORE_URLS=http://*:5101/
 EXPOSE 5101
+# Create the storage folder if it isn't mapped to a volume runtime
+RUN mkdir /AltinnPlatformLocal
 WORKDIR /app
 COPY --from=build /app_output .
 
 # Copy various data
 COPY ./testdata /testdata
+HEALTHCHECK --interval=1s --timeout=1s --retries=20 \
+    CMD wget -nv -t1 --spider 'http://localhost:5101/health' || exit 1
 
 # setup the user and group (not important for LocalTest and this removes write access to /AltinnPlatformLocal)
 # RUN addgroup -g 3000 dotnet && adduser -u 1000 -G dotnet -D -s /bin/false dotnet

docker-compose.yml

@@ -66,7 +66,6 @@ services:
       context: .
     environment:
       - DOTNET_ENVIRONMENT=Docker
-      - ASPNETCORE_URLS=http://*:5101/
       - GeneralSettings__BaseUrl=http://${TEST_DOMAIN:-local.altinn.cloud}:${ALTINN3LOCAL_PORT:-80}
       - GeneralSettings__HostName=${TEST_DOMAIN:-local.altinn.cloud}
     volumes:

podman-compose.yml

@@ -63,7 +63,6 @@ services:
       context: .
     environment:
       - DOTNET_ENVIRONMENT=Podman
-      - ASPNETCORE_URLS=http://*:5101/
       - GeneralSettings__BaseUrl=http://${TEST_DOMAIN:-local.altinn.cloud}:${ALTINN3LOCAL_PORT:-8000}
       - GeneralSettings__HostName=${TEST_DOMAIN:-local.altinn.cloud}
     volumes:

src/Controllers/Authorization/DecisionController.cs

@@ -197,6 +197,7 @@ private async Task<ActionResult> AuthorizeJsonRequest(XacmlRequestApiModel model
             XacmlJsonRequestRoot jsonRequest = (XacmlJsonRequestRoot)JsonConvert.DeserializeObject(model.BodyContent, typeof(XacmlJsonRequestRoot));
 
             XacmlJsonResponse jsonResponse = await Authorize(jsonRequest.Request);
+            _logger.LogInformation($"Decision: {jsonResponse.Response[0].Decision}");
 
             return Ok(jsonResponse);
         }
@@ -210,6 +211,7 @@ private ActionResult CreateResponse(XacmlContextResponse xacmlContextResponse)
             }
 
             string xml = builder.ToString();
+            _logger.LogInformation($"Decision: {xacmlContextResponse}");
 
             return Content(xml);
         }

src/Controllers/HomeController.cs

@@ -146,9 +146,6 @@ public async Task<ActionResult> LogInTestUser(string action, StartAppModel start
 
             Application app = await _localApp.GetApplicationMetadata(startAppModel.AppPathSelection);
 
-            // Ensure that the documentstorage in LocalTestingStorageBasePath is updated with the most recent app data
-            await _applicationRepository.Update(app);
-
             if (_localPlatformSettings.LocalAppMode == "http")
             {
                 // Instantiate a prefill if a file attachment exists.

src/Filters/ProxyMiddleware.cs

@@ -0,0 +1,89 @@
+#nullable enable
+using System.Diagnostics;
+using System.Net;
+using System.Text.RegularExpressions;
+using LocalTest.Configuration;
+using Microsoft.Extensions.Options;
+using Yarp.ReverseProxy.Forwarder;
+
+namespace LocalTest.Filters;
+
+public class ProxyMiddleware
+{
+    private readonly RequestDelegate _nextMiddleware;
+    private readonly IOptions<LocalPlatformSettings> localPlatformSettings;
+    private readonly IHttpForwarder _forwarder;
+
+    public ProxyMiddleware(
+        RequestDelegate nextMiddleware,
+        IOptions<LocalPlatformSettings> localPlatformSettings,
+        IHttpForwarder forwarder
+    )
+    {
+        _nextMiddleware = nextMiddleware;
+        this.localPlatformSettings = localPlatformSettings;
+        _forwarder = forwarder;
+    }
+
+    private static readonly List<Regex> _noProxies =
+        new()
+        {
+            new Regex("^/$"),
+            new Regex("^/Home/"),
+            new Regex("^/localtestresources/"),
+            new Regex("^/LocalPlatformStorage/"),
+            new Regex("^/authentication/"),
+            new Regex("^/authorization/"),
+            new Regex("^/profile/"),
+            new Regex("^/events/"),
+            new Regex("^/register/"),
+            new Regex("^/storage/"),
+        };
+
+    public async Task Invoke(HttpContext context)
+    {
+        var path = context.Request.Path.Value;
+        if (path == null)
+        {
+            await _nextMiddleware(context);
+            return;
+        }
+        // TODO: only proxy requests to the actually running app
+        foreach (var noProxy in _noProxies)
+        {
+            if (noProxy.IsMatch(path))
+            {
+                await _nextMiddleware(context);
+                return;
+            }
+        }
+        await ProxyRequest(context, localPlatformSettings.Value.LocalAppUrl);
+        return;
+    }
+
+    public static HttpMessageInvoker _httpClient = new HttpMessageInvoker(
+        new SocketsHttpHandler
+        {
+            UseProxy = false,
+            AllowAutoRedirect = false,
+            AutomaticDecompression = DecompressionMethods.None,
+            UseCookies = false,
+            EnableMultipleHttp2Connections = true,
+            ActivityHeadersPropagator = new ReverseProxyPropagator(
+                DistributedContextPropagator.Current
+            ),
+            ConnectTimeout = TimeSpan.FromSeconds(15),
+        }
+    );
+
+    public async Task ProxyRequest(HttpContext context, string newHost)
+    {
+        var error = await _forwarder.SendAsync(context, newHost, _httpClient);
+        // Check if the operation was successful
+        if (error != ForwarderError.None)
+        {
+            var errorFeature = context.GetForwarderErrorFeature();
+            throw errorFeature?.Exception ?? new Exception("Forwarder error");
+        }
+    }
+}

src/LocalTest.csproj

@@ -28,6 +28,7 @@
     <PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="8.0.*" />
     <PackageReference Include="Microsoft.Extensions.Http" Version="8.0.*" />
     <PackageReference Include="System.IO.Hashing" Version="8.0.0" />
+    <PackageReference Include="Yarp.ReverseProxy" Version="2.2.0" />
   </ItemGroup>
 
   <ItemGroup>

src/Services/Storage/Implementation/ApplicationRepository.cs

@@ -9,18 +9,20 @@
 using Altinn.Platform.Storage.Repository;
 
 using LocalTest.Configuration;
-
+using LocalTest.Services.LocalApp.Interface;
 using Microsoft.Extensions.Options;
 
 namespace LocalTest.Services.Storage.Implementation
 {
     public class ApplicationRepository : IApplicationRepository
     {
         private readonly LocalPlatformSettings _localPlatformSettings;
+        private readonly ILocalApp _localApp;
 
-        public ApplicationRepository(IOptions<LocalPlatformSettings> localPlatformSettings)
+        public ApplicationRepository(IOptions<LocalPlatformSettings> localPlatformSettings, ILocalApp localApp)
         {
             _localPlatformSettings = localPlatformSettings.Value;
+            _localApp = localApp;
         }
 
         public Task<Application> Create(Application item)
@@ -35,16 +37,11 @@ public Task<bool> Delete(string appId, string org)
 
         public async Task<Application> FindOne(string appId, string org)
         {
-            var filename = GetApplicationsDirectory() + appId + ".json";
-            if (File.Exists(filename))
+            var applications = await _localApp.GetApplications();
+            if (applications.ContainsKey(appId))
             {
-                var application = JsonSerializer.Deserialize<Application>(await File.ReadAllTextAsync(filename));
-                if (application is not null)
-                {
-                    return application;
-                }
+                return applications[appId];
             }
-
             throw new Exception($"applicationmetadata for '{appId} not found'");
         }
 
@@ -55,13 +52,9 @@ public Task<Dictionary<string, Dictionary<string, string>>> GetAppTitles(List<st
 
         public async Task<List<Application>> FindByOrg(string org)
         {
-            var apps = new List<Application>();
-            foreach (var app in Directory.GetFiles(GetApplicationsDirectory() + org))
-            {
-                apps.Add(JsonSerializer.Deserialize<Application>(await File.ReadAllTextAsync(app)));
-            }
+            var applications = await _localApp.GetApplications();
 
-            return apps;
+            return applications.Values.Where(a=>a.Org == org).ToList();
         }
 
         public async Task<Application> Update(Application item)
@@ -78,13 +71,8 @@ public async Task<Application> Update(Application item)
 
         public async Task<List<Application>> FindAll()
         {
-            var apps = new List<Application>();
-            foreach (var org in (new DirectoryInfo(GetApplicationsDirectory()).GetDirectories()))
-            {
-                apps.AddRange(await FindByOrg(org.Name));
-            }
-
-            return apps;
+            var applications = await _localApp.GetApplications();
+            return applications.Values.ToList();
         }
 
         public Task<Dictionary<string, string>> GetAllAppTitles()

src/Startup.cs

@@ -26,6 +26,7 @@
 using AltinnCore.Authentication.JwtCookie;
 using LocalTest.Clients.CdnAltinnOrgs;
 using LocalTest.Configuration;
+using LocalTest.Filters;
 using LocalTest.Helpers;
 using LocalTest.Notifications.LocalTestNotifications;
 using LocalTest.Services.AccessManagement;
@@ -204,6 +205,10 @@ public void ConfigureServices(IServiceCollection services)
             }
 
             services.AddTransient<ILocalFrontendService, LocalFrontendService>();
+
+            services.AddHttpForwarder();
+
+            services.AddHealthChecks();
         }
 
         // This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
@@ -225,6 +230,9 @@ public void Configure(
                 // The default HSTS value is 30 days. You may want to change this for production scenarios, see https://aka.ms/aspnetcore-hsts.
                 app.UseHsts();
             }
+
+            app.UseHealthChecks("/health");
+            app.UseMiddleware<ProxyMiddleware>();
 
             var storagePath = new DirectoryInfo(localPlatformSettings.Value.LocalTestingStorageBasePath);
             if (!storagePath.Exists)