-
Notifications
You must be signed in to change notification settings - Fork 2
feat(frontend): add event tracking #2730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
| SAVED_SEARCH_CREATE_FAILED: 'SavedSearch.Create.Failed', | ||
| SAVED_SEARCH_DELETE_SUCCESS: 'SavedSearch.Delete.Success', | ||
| SAVED_SEARCH_DELETE_FAILED: 'SavedSearch.Delete.Failed', | ||
| SAVED_SEARCH_UPDATE_SUCCESS: 'SavedSearch.Update.Success', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name is probably a bit misleading elsewhere in the code, but the only thing the user can do here, as might be aware of, is give the saved search a name. And of course, it's possible to update without giving a name. Basically doing nothing.
A proposal:
What if we have an event called SAVED_SEARCH_NAME_UPDATED which requires a success update of a saved search AND the payload had a title.
I think this is fruitful to see whether the users understand the mechanics here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not quite sure what you mean, but added an if-statement to check if the title is defined before tracking a successful event ( if that's what you mean)
| <Button | ||
| variant="outline" | ||
| onClick={() => { | ||
| Analytics.trackEvent(ANALYTICS_EVENTS.DIALOG_TRANSMISSIONS_EXPAND, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like tracking this, very clever!
|



Hva er endret?
Related Issue(s)