Skip to content

Conversation

@arealmaas
Copy link
Collaborator

@arealmaas arealmaas commented Sep 16, 2025

@sonarqubecloud
Copy link

SAVED_SEARCH_CREATE_FAILED: 'SavedSearch.Create.Failed',
SAVED_SEARCH_DELETE_SUCCESS: 'SavedSearch.Delete.Success',
SAVED_SEARCH_DELETE_FAILED: 'SavedSearch.Delete.Failed',
SAVED_SEARCH_UPDATE_SUCCESS: 'SavedSearch.Update.Success',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name is probably a bit misleading elsewhere in the code, but the only thing the user can do here, as might be aware of, is give the saved search a name. And of course, it's possible to update without giving a name. Basically doing nothing.

A proposal:

What if we have an event called SAVED_SEARCH_NAME_UPDATED which requires a success update of a saved search AND the payload had a title.
I think this is fruitful to see whether the users understand the mechanics here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not quite sure what you mean, but added an if-statement to check if the title is defined before tracking a successful event ( if that's what you mean)

<Button
variant="outline"
onClick={() => {
Analytics.trackEvent(ANALYTICS_EVENTS.DIALOG_TRANSMISSIONS_EXPAND, {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like tracking this, very clever!

@sonarqubecloud
Copy link

@arealmaas arealmaas marked this pull request as ready for review October 20, 2025 09:18
@arealmaas arealmaas requested a review from a team as a code owner October 20, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants