MIME-type validering - Uploaded file extension samme som filename extension #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+32
to
+46
| foreach (var fileExtension in fileMimeTypeResult.Extensions) | ||
| { | ||
| if (fileMimeTypeResult.Filename != null && !fileMimeTypeResult.Filename.EndsWith(fileExtension)) | ||
| { | ||
| ValidationIssue error = new() | ||
| { | ||
| Source = "File", | ||
| Code = "Uploaded file extension is not the same as filename extension", // TODO - Add correct code | ||
| Severity = ValidationIssueSeverity.Error, | ||
| Description = $"The {fileMimeTypeResult.Filename} filename does not appear to have the same extension as uploaded file. File extension on uploaded file is .{fileExtension}" | ||
| }; | ||
|
|
||
| errors.Add(error); | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Where
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Vi har en dataType "Gjennomfoeringsplan" som har "allowedContentTypes": [ "application/pdf", "application/xml" ]
Dersom vi laster opp en xml-fil og setter headers med Content-type: "application/pdf" og Content-Disposition: "attachment; filename={{dataType}}.pdf", vil filen bli lastet opp uten valideringsfeil. På instansen vil det nå ligge et dataElement som har "filename" og "contentType" som tilsier at det er en PDF, men når man ser på innholdet så er det en XML.
Vi ønsker å validere innholdet i filen dersom det er en xml, og vil gjerne stole på at contentType og extension på filename faktisk stemmer overens med innholdet, så man kan sjekke basert på det.
MimeTypeValidator bør derfor sjekke file extension på opplastet fil, mot filename fra header.
Related Issue(s)
Verification
Documentation