Feature/configurable ignore reservation #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed UseAltinnTestServers boolean property from Settings and interface - Added BaseUrl property with URL validation (Required, Url attributes) - Updated DdMessagingService to use settings.BaseUrl directly - Updated all test files and SettingsBuilder to use WithBaseUrl() method - Updated appsettings.json.template with BaseUrl configuration - Updated README.md documentation to reflect BaseUrl usage
- Added AddDdMessagingServiceSettingsJwkClientDefinition method that takes a single config section - Method extracts MaskinportenSettings and CorrespondenceSettings sub-sections internally - Follows Dialogporten pattern for cleaner API (no double config parameters) - Updated SendDdCorrespondence/Program.cs to use the new simplified method - Updated README.md to show new method as recommended approach - Generic method still available for custom client definitions
- Updated WithValidDefaults() to accept optional correspondenceSettings and baseUrl parameters - Removed WithProductionSettings() method (redundant with configurable parameters) - Fixed misleading test resource IDs when using production URLs - Added missing BaseUrl to test that was missing it - Both parameters now have sensible test defaults but can be overridden - Prevents mismatched configurations (e.g., test resource IDs with prod URL)
- Removed all legacy/obsolete classes and methods: * Old Settings class and IDdNotificationSettings interface * Obsolete AddDdMessagingService methods * LegacySettingsAdapter and old test builders * Outdated integration and model tests - Unified to clean Dialogporten-style API: * Single AddCorrespondenceClient method * CorrespondenceSettings with nested Maskinporten config * Updated DdMessagingService to use IOptions<CorrespondenceSettings> - Updated example project configuration structure - All tests passing, SendDdCorrespondence working end-to-end
- Remove SendDdCorrespondence/appsettings-dialogporten-style.json (contains sensitive tokens) - Update .gitignore to prevent similar files from being committed
…e to .NET 10 - Migrate all projects from .NET 8 to .NET 10 - Add global.json files to pin SDK version (10.0.100) - Restructure folders to match Dialogporten conventions: - Exceptions/ → Common/Exceptions/ - ExternalServices/ → Infrastructure/ - Add AssemblyMarker.cs following Dialogporten pattern - Add Directory.Build.props for framework overrides - Apply sealed keyword to CorrespondenceSettings and exceptions - Update package metadata (LICENSE, documentation generation) - Update all namespace references across projects - All 36 tests pass successfully BREAKING CHANGE: Namespace changes require updates: - Altinn.Dd.Correspondence.Exceptions → Altinn.Dd.Correspondence.Common.Exceptions - Altinn.Dd.Correspondence.ExternalServices.Correspondence → Altinn.Dd.Correspondence.Infrastructure
…enceServiceException Add missing using statement for Common.Exceptions namespace to fix CS1574 warning in IDdMessagingService interface documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.