Hyva default theme update "Could not detect plugins for the following files"

[jmpb]

I am working through updating our hyva-themes/magento2-default-theme using the provided instructions. We are on Magento 2.4.6-p11. There are quite a lot of versions we need to catch up on so I am doing them one by one and on the 1.2.8 upgrade I am getting;

Could not detect plugins for the following files
vendor/hyva-themes/magento2-theme-module/src/ViewModel/ProductList.php - on line 484 -         return $this->scopeConfig->getValue(self::XML_CROSSSELL_PRODUCTS_LIMIT, ConfigScope::SCOPE_STORE); does not equal         $value = $this->scopeConfig->getValue(self::XML_CROSSSELL_PRODUCTS_LIMIT, ConfigScope::SCOPE_STORE);
Please raise a github issue with the above error information and the contents of /var/www/html/vendor_files_error.patch

The contents of the vendor_files_error.patch file are;

diff -ur -N vendor_orig/hyva-themes/magento2-theme-module/src/ViewModel/ProductList.php vendor/hyva-themes/magento2-theme-module/src/ViewModel/ProductList.php
--- vendor_orig/hyva-themes/magento2-theme-module/src/ViewModel/ProductList.php 2024-05-09 16:32:54.000000000 +0100
+++ vendor/hyva-themes/magento2-theme-module/src/ViewModel/ProductList.php      2025-07-03 12:33:27.000000000 +0100
@@ -481,7 +481,9 @@
 
     public function getConfiguredMaxCrosssellItemCount(): ?int
     {
-        return $this->scopeConfig->getValue(self::XML_CROSSSELL_PRODUCTS_LIMIT, ConfigScope::SCOPE_STORE);
+        $value = $this->scopeConfig->getValue(self::XML_CROSSSELL_PRODUCTS_LIMIT, ConfigScope::SCOPE_STORE);
+
+        return $value !== null && $value !== '' ? (int)$value : null;
     }
 
     public function includeReviewSummary(): self

and the contents of the getConfiguredMaxCrosssellItemCount method in the vendor file in the vendor folder is;

    public function getConfiguredMaxCrosssellItemCount(): ?int
    {
        $value = $this->scopeConfig->getValue(self::XML_CROSSSELL_PRODUCTS_LIMIT, ConfigScope::SCOPE_STORE);

        return $value !== null && $value !== '' ? (int)$value : null;
    }

So it looks to be patched already, unless I am missing something.

I have tried completely removing all vendor/ files and re-running composer install again a few times. I have also tried patching with our own patch and also moving on to the next update (1.2.9) to see if it would resolve itself.

These are relatively small updates (at least for us) and the respective customer files in the theme are not overidden but I am hesitant to move on until I know the patch helper is working correctly.

the patch-helper-output.txt file generated from the analyse command contains;

+-------+------+------+----------+
| Level | Type | File | To Check |
+-------+------+------+----------+
WARN count: 0
INFO count: 1 (to view re-run this tool with --show-info)
IGNORE count: 21 (to view re-run this tool with --show-ignore)
For docs on each check see https://github.com/AmpersandHQ/ampersand-magento2-upgrade-patch-helper/blob/master/docs/CHECKS_AVAILABLE.md
You should review the above 0 items alongside /var/www/html/vendor_files_to_check.patch

Which I believe may be correct but I am unsure if the error is halting progress in the checks?

[convenient]

Hello

This error should not be halting the progress of the checks. The tool is built so if one check fails, then at least the others will continue to execute and provide value.

Good job debugging thus far, this is good information that needs a review.

If you want to see the full list of of files being scanned and checked you can run it with -vvv