fix: issue detecting proper message from certain virtual machine errors (#111)

Author: antazoey

ape_foundry/provider.py

@@ -616,7 +616,15 @@ def get_virtual_machine_error(self, exception: Exception, **kwargs) -> VirtualMa
             return VirtualMachineError(base_err=exception, **kwargs)
 
         err_data = exception.args[0]
-        message = str(err_data.get("message")) if isinstance(err_data, dict) else err_data
+
+        if isinstance(err_data, dict):
+            message = str(err_data.get("message", f"{err_data}"))
+        elif isinstance(err_data, str):
+            message = err_data
+        elif msg := getattr(exception, "message", ""):
+            message = msg
+        else:
+            message = ""
 
         if not message:
             return VirtualMachineError(base_err=exception, **kwargs)

tests/test_provider.py

@@ -5,7 +5,7 @@
 from ape.api import TraceAPI
 from ape.api.accounts import ImpersonatedAccount
 from ape.contracts import ContractContainer
-from ape.exceptions import ContractLogicError, TransactionError
+from ape.exceptions import ContractLogicError, TransactionError, VirtualMachineError
 from ape_ethereum.trace import Trace
 from ape_ethereum.transactions import TransactionStatusEnum, TransactionType
 from eth_pydantic_types import HashBytes32
@@ -348,6 +348,13 @@ def test_get_virtual_machine_error_from_contract_logic_message_includes_base_err
     assert actual.base_err == exception
 
 
+def test_get_virtual_machine_error_first_arg_not_message(connected_provider):
+    # Handling weird edge case I have not seen in the wild but was raised in a GH issue.
+    exception = Exception(Exception())
+    actual = connected_provider.get_virtual_machine_error(exception)
+    assert isinstance(actual, VirtualMachineError)
+
+
 def test_no_mining(project, local_network, connected_provider):
     assert "--no-mining" not in connected_provider.build_command()
     with project.temp_config(foundry={"auto_mine": "false"}):