fix: replace printStackTrace() calls with proper logging

carlesarnal · carlesarnal · commit 40f92a718075 · 2026-01-02T13:53:28.000+01:00
Replace all printStackTrace() calls with proper SLF4J logging throughout the codebase: - Production code: Use log.error(), log.warn(), or log.debug() as appropriate - Test code: Use logger from base class or add SLF4J logger - Examples: Use System.err.println() for standalone demo apps - Build tools: Add SLF4J logging Also added slf4j-api dependency to schema-resolver module. Fixes #7070
diff --git a/app/src/test/java/io/apicurio/registry/noprofile/rest/v3/AllYamlTest.java b/app/src/test/java/io/apicurio/registry/noprofile/rest/v3/AllYamlTest.java
@@ -18,12 +18,16 @@
 import io.quarkus.test.junit.QuarkusTest;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.util.UUID;
 
 @QuarkusTest
 public class AllYamlTest extends AbstractResourceTestBase {
 
+    private static final Logger log = LoggerFactory.getLogger(AllYamlTest.class);
+
     private static String YAML_CONTENT = """
             openapi: 3.0.2
             info:
@@ -125,8 +129,7 @@ public void testCreateYamlArtifactWithValidity() throws Exception {
                     YAML_CONTENT, ContentTypes.APPLICATION_YAML);
             clientV3.groups().byGroupId(groupId).artifacts().post(createArtifact);
         } catch (ProblemDetails e) {
-            System.out.println("ERROR: " + e.getDetail());
-            e.getCause().printStackTrace();
+            log.error("Failed to create YAML artifact: {}", e.getDetail(), e.getCause());
             throw e;
         }
     }
diff --git a/app/src/test/java/io/apicurio/registry/noprofile/rest/v3/ImportExportTest.java b/app/src/test/java/io/apicurio/registry/noprofile/rest/v3/ImportExportTest.java
@@ -30,6 +30,8 @@
 import jakarta.inject.Inject;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.File;
 import java.io.FileInputStream;
@@ -47,6 +49,8 @@
 @QuarkusTest
 public class ImportExportTest extends AbstractResourceTestBase {
 
+    private static final Logger log = LoggerFactory.getLogger(ImportExportTest.class);
+
     @Inject
     @Current
     RegistryStorage storage;
@@ -334,17 +338,17 @@ private static void downloadTo(URL url, File tempFile) {
     }
 
     private static void listFiles(File tempFile) {
-        System.out.println("--- Export ZIP File Listing ---");
+        log.debug("--- Export ZIP File Listing ---");
         try (ZipFile zipFile = new ZipFile(tempFile)) {
             Enumeration<? extends ZipEntry> entries = zipFile.entries();
             while (entries.hasMoreElements()) {
                 ZipEntry entry = entries.nextElement();
-                System.out.println(entry.getName());
+                log.debug(entry.getName());
             }
         } catch (IOException e) {
-            e.printStackTrace();
+            log.warn("Failed to list ZIP file entries", e);
         }
-        System.out.println("--- Export ZIP File Listing ---");
+        log.debug("--- Export ZIP File Listing ---");
     }
 
 }
diff --git a/docs/config-generator/src/main/java/io/apicurio/registry/docs/GenerateAllConfigPartial.java b/docs/config-generator/src/main/java/io/apicurio/registry/docs/GenerateAllConfigPartial.java
@@ -7,6 +7,8 @@
 import org.jboss.jandex.IndexReader;
 import org.jboss.jandex.Main;
 import org.jboss.jandex.Type;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.FileInputStream;
 import java.io.FileNotFoundException;
@@ -51,6 +53,8 @@
  */
 public class GenerateAllConfigPartial {
 
+    private static final Logger log = LoggerFactory.getLogger(GenerateAllConfigPartial.class);
+
     private static Map<String, Option> allConfiguration = new HashMap();
     private static Set<String> skipProperties = Set.of("quarkus.oidc.auth-server-url");
 
@@ -161,19 +165,21 @@ public static Map<String, Option> extractConfigurations(String jarFile, Map<Stri
         try {
             input = new FileInputStream(jarFile.replace(".jar", "-jar.idx"));
         } catch (FileNotFoundException e) {
-            e.printStackTrace();
+            log.error("Jandex index file not found for JAR: {}", jarFile, e);
+            throw new RuntimeException("Jandex index file not found", e);
         }
         IndexReader reader = new IndexReader(input);
         Index index = null;
         try {
             index = reader.read();
         } catch (IOException e) {
-            e.printStackTrace();
+            log.error("Failed to read Jandex index for JAR: {}", jarFile, e);
+            throw new RuntimeException("Failed to read Jandex index", e);
         } finally {
             try {
                 input.close();
             } catch (IOException e) {
-                e.printStackTrace();
+                log.warn("Failed to close Jandex index input stream", e);
             }
         }
 
@@ -322,7 +328,7 @@ public static void main(String... args) throws Exception {
             //load a properties file from class path, inside static method
             props.load(new FileInputStream(baseDir + "/../app/src/main/resources/application.properties"));
         } catch (Exception e) {
-            e.printStackTrace();
+            log.warn("Failed to load application.properties for configuration extraction", e);
         }
         for (var prop : props.entrySet()) {
 
diff --git a/examples/mtls-minikube/client/src/main/java/io/apicurio/registry/examples/mtls/MtlsClientDemo.java b/examples/mtls-minikube/client/src/main/java/io/apicurio/registry/examples/mtls/MtlsClientDemo.java
@@ -161,8 +161,10 @@ public static void main(String[] args) {
             }
 
             System.err.println();
-            System.err.println("Error details:");
-            e.printStackTrace();
+            System.err.println("Error details: " + e.getMessage());
+            if (e.getCause() != null) {
+                System.err.println("Caused by: " + e.getCause().getMessage());
+            }
             System.exit(1);
         } finally {
             // Clean up Vert.x instance
diff --git a/examples/simple-validation/src/main/java/io/apicurio/registry/examples/simple/json/MessagePublisher.java b/examples/simple-validation/src/main/java/io/apicurio/registry/examples/simple/json/MessagePublisher.java
@@ -59,7 +59,6 @@ public void publishMessage(MessageBean message) {
             }
         } catch (Exception e) {
             System.err.println("Error publishing message: " + e.getMessage());
-            e.printStackTrace();
         }
     }
 
diff --git a/examples/simple-validation/src/main/java/io/apicurio/registry/examples/simple/json/SimpleBroker.java b/examples/simple-validation/src/main/java/io/apicurio/registry/examples/simple/json/SimpleBroker.java
@@ -57,7 +57,7 @@ public void start() {
 
             server.start();
         } catch (Throwable tr) {
-            tr.printStackTrace();
+            System.err.println("Failed to start SimpleBroker: " + tr.getMessage());
         }
     }
 
diff --git a/integration-tests/src/test/java/io/apicurio/tests/auth/SimpleAuthIT.java b/integration-tests/src/test/java/io/apicurio/tests/auth/SimpleAuthIT.java
@@ -157,7 +157,7 @@ public void testDevRole() throws Exception {
             try {
                 client.groups().byGroupId(groupId).artifacts().byArtifactId(artifactId).delete();
             } catch (Exception ex) {
-                ex.printStackTrace();
+                logger.warn("Failed to delete test artifact during cleanup", ex);
             }
         }
     }
@@ -199,7 +199,7 @@ public void testAdminRole() throws Exception {
             try {
                 client.groups().byGroupId(groupId).artifacts().byArtifactId(artifactId).delete();
             } catch (Exception ex) {
-                ex.printStackTrace();
+                logger.warn("Failed to delete test artifact during cleanup", ex);
             }
         }
     }
diff --git a/integration-tests/src/test/java/io/apicurio/tests/migration/GenerateCanonicalHashImportIT.java b/integration-tests/src/test/java/io/apicurio/tests/migration/GenerateCanonicalHashImportIT.java
@@ -22,6 +22,8 @@
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
@@ -44,6 +46,8 @@
 @Disabled
 public class GenerateCanonicalHashImportIT extends ApicurioRegistryBaseIT {
 
+    private static final Logger log = LoggerFactory.getLogger(GenerateCanonicalHashImportIT.class);
+
     @Test
     public void testGeneratingCanonicalHashOnImport() throws Exception {
         Vertx vertx = Vertx.vertx();
@@ -171,7 +175,7 @@ public InputStream generateExportedZip(Map<String, String> artifacts) {
 
             return new ByteArrayInputStream(outputStream.toByteArray());
         } catch (IOException e) {
-            e.printStackTrace();
+            log.error("Failed to generate exported ZIP", e);
         }
         return null;
     }
diff --git a/integration-tests/src/test/java/io/apicurio/tests/migration/MigrationTestsDataInitializer.java b/integration-tests/src/test/java/io/apicurio/tests/migration/MigrationTestsDataInitializer.java
@@ -33,13 +33,18 @@
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.zip.ZipOutputStream;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import static io.apicurio.tests.migration.DataMigrationIT.doNotPreserveIdsImportArtifacts;
 import static io.apicurio.tests.migration.DataMigrationIT.migrateGlobalIds;
 import static io.apicurio.tests.migration.DataMigrationIT.migrateReferencesMap;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 public class MigrationTestsDataInitializer {
 
+    private static final Logger log = LoggerFactory.getLogger(MigrationTestsDataInitializer.class);
+
     public static void initializeMigrateTest(io.apicurio.registry.rest.client.v2.RegistryClient source,
             String registryBaseUrl) throws Exception {
         migrateGlobalIds = new ArrayList<>();
@@ -293,7 +298,7 @@ public InputStream generateExportedZip(Map<String, String> artifacts) {
 
             return new ByteArrayInputStream(outputStream.toByteArray());
         } catch (IOException e) {
-            e.printStackTrace();
+            log.error("Failed to generate exported ZIP", e);
         }
         return null;
     }
diff --git a/schema-resolver/pom.xml b/schema-resolver/pom.xml
@@ -31,6 +31,11 @@
       <artifactId>apicurio-registry-common</artifactId>
     </dependency>
 
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-api</artifactId>
+    </dependency>
+
     <dependency>
       <groupId>org.projectlombok</groupId>
       <artifactId>lombok</artifactId>
diff --git a/schema-resolver/src/main/java/io/apicurio/registry/resolver/cache/ERCache.java b/schema-resolver/src/main/java/io/apicurio/registry/resolver/cache/ERCache.java
@@ -2,6 +2,8 @@
 
 import com.microsoft.kiota.ApiException;
 import io.apicurio.registry.resolver.strategy.ArtifactCoordinates;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.time.Duration;
 import java.time.Instant;
@@ -17,6 +19,8 @@
  */
 public class ERCache<V> {
 
+    private static final Logger log = LoggerFactory.getLogger(ERCache.class);
+
     private final Map<Long, WrappedValue<V>> globalIdIndex = new ConcurrentHashMap<>();
     private final Map<ContentWithReferences, WrappedValue<V>> contentIndex = new ConcurrentHashMap<>();
     private final Map<Long, WrappedValue<V>> contentIdIndex = new ConcurrentHashMap<>();
@@ -238,15 +242,15 @@ private static <T> Result<T, RuntimeException> retry(Duration backoff, long retr
                 // && (((ApiException) e.getCause().getCause()).getResponseStatusCode() == 429)))
                 if (i == retries || !(e.getCause() != null && e.getCause() instanceof ApiException
                         && (((ApiException) e.getCause()).getResponseStatusCode() == 429))) {
-                    e.printStackTrace();
+                    log.error("Cache load failed after {} retries", i, e);
                     return Result.error(new RuntimeException(e));
                 }
             }
             try {
                 Thread.sleep(backoff.toMillis());
             } catch (InterruptedException e) {
-                // Ignore
-                e.printStackTrace();
+                log.debug("Cache retry backoff interrupted", e);
+                Thread.currentThread().interrupt();
             }
         }
         return Result.error(new IllegalStateException("Unreachable."));
diff --git a/schema-util/graphql/src/main/java/io/apicurio/registry/graphql/rules/validity/GraphQLContentValidator.java b/schema-util/graphql/src/main/java/io/apicurio/registry/graphql/rules/validity/GraphQLContentValidator.java
@@ -7,6 +7,8 @@
 import io.apicurio.registry.rules.validity.ValidityLevel;
 import io.apicurio.registry.rules.violation.RuleViolationException;
 import io.apicurio.registry.types.RuleType;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.util.List;
 import java.util.Map;
@@ -16,6 +18,8 @@
  */
 public class GraphQLContentValidator implements ContentValidator {
 
+    private static final Logger log = LoggerFactory.getLogger(GraphQLContentValidator.class);
+
     /**
      * Constructor.
      */
@@ -32,7 +36,7 @@ public void validate(ValidityLevel level, TypedContent content,
             try {
                 new SchemaParser().parse(content.getContent().content());
             } catch (Exception e) {
-                e.printStackTrace();
+                log.debug("GraphQL schema validation failed", e);
                 throw new RuleViolationException("Syntax violation for GraphQL artifact.", RuleType.VALIDITY,
                         level.name(), e);
             }
diff --git a/utils/tests/src/main/java/io/apicurio/registry/utils/tests/TestUtils.java b/utils/tests/src/main/java/io/apicurio/registry/utils/tests/TestUtils.java
@@ -212,7 +212,7 @@ public static long waitFor(String description, long pollIntervalMs, long timeout
                 onTimeout.run();
                 TimeoutException exception = new TimeoutException(
                         "Timeout after " + timeoutMs + " ms waiting for " + description);
-                exception.printStackTrace();
+                log.warn("Timeout waiting for: {}", description, exception);
                 throw exception;
             }
             long sleepTime = Math.min(pollIntervalMs, timeLeft);

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,6 @@ public void publishMessage(MessageBean message) {`
`59`	`59`	`}`
`60`	`60`	`} catch (Exception e) {`
`61`	`61`	`System.err.println("Error publishing message: " + e.getMessage());`
`62`		`- e.printStackTrace();`
`63`	`62`	`}`
`64`	`63`	`}`
`65`	`64`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ public void start() {`
`57`	`57`
`58`	`58`	`server.start();`
`59`	`59`	`} catch (Throwable tr) {`
`60`		`- tr.printStackTrace();`
	`60`	`+ System.err.println("Failed to start SimpleBroker: " + tr.getMessage());`
`61`	`61`	`}`
`62`	`62`	`}`
`63`	`63`
Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ public void testDevRole() throws Exception {`
`157`	`157`	`try {`
`158`	`158`	`client.groups().byGroupId(groupId).artifacts().byArtifactId(artifactId).delete();`
`159`	`159`	`} catch (Exception ex) {`
`160`		`- ex.printStackTrace();`
	`160`	`+ logger.warn("Failed to delete test artifact during cleanup", ex);`
`161`	`161`	`}`
`162`	`162`	`}`
`163`	`163`	`}`
`@@ -199,7 +199,7 @@ public void testAdminRole() throws Exception {`
`199`	`199`	`try {`
`200`	`200`	`client.groups().byGroupId(groupId).artifacts().byArtifactId(artifactId).delete();`
`201`	`201`	`} catch (Exception ex) {`
`202`		`- ex.printStackTrace();`
	`202`	`+ logger.warn("Failed to delete test artifact during cleanup", ex);`
`203`	`203`	`}`
`204`	`204`	`}`
`205`	`205`	`}`