Artifact search returns incorrect artifacts

[jonsnowseven]

SDK client returns an artifact incorrectly if the artifact name is contained in an existing one.

Description

Registry
Version: 3.0.9
Persistence type: sql

Environment

Steps to Reproduce

1. Register an AVRO artifact with group id group and name name-test
2. Run

    client.search().artifacts().get(
               getRequestConfiguration -> {
                 checkNotNull(getRequestConfiguration.queryParameters);
                 getRequestConfiguration.queryParameters.name = "name";
                 getRequestConfiguration.queryParameters.groupId = "group";
               });

3. It returns the artifact with group id group and name name-test

Expected vs Actual Behaviour

The SDK should not return any result but returns an artifact.

Logs

[EricWittmann]

I think this is actually working as intended, but I agree could be improved. Some of the filters (query params) on the search endpoints are intended to be "LIKE" queries essentially. That said, it would be nice if the filtering supported both = and LIKE queries, based on the value of the query param. So perhaps a value of *name* would result in a LIKE query, but a value of name would result in an exact match.

Thoughts?

[jonsnowseven]

Thanks for the answer!
So the search by name would work with wildcards?

[EricWittmann]

Yeah I am proposing that, in a future version of Registry, we would change these filters to support wildcards in the query param values. We currently do not support that.

[EricWittmann]

Of course, that is a mildly breaking API change, so it would need to be done in version 3.1 at the earliest.

[jonsnowseven]

Can you share a snippet of what would change?

[EricWittmann]

Sure. It would start with SearchResourceImpl here:

https://github.com/Apicurio/apicurio-registry/blob/3.1.x/app/src/main/java/io/apicurio/registry/rest/v3/SearchResourceImpl.java#L63-L65

That's the JAX-RS endpoint for "search artifacts" as an example. Each query param is there as a param to the java method. So name, description, artifactId, etc.

We create a filter for e.g. name here:

https://github.com/Apicurio/apicurio-registry/blob/3.1.x/app/src/main/java/io/apicurio/registry/rest/v3/SearchResourceImpl.java#L81-L83

Then we call the storage to perform the search using the collection of filters:

https://github.com/Apicurio/apicurio-registry/blob/3.1.x/app/src/main/java/io/apicurio/registry/rest/v3/SearchResourceImpl.java#L127-L128

The filters are applied in the storage when creating the SQL query that will ultimately be used to fetch the data from the DB:

https://github.com/Apicurio/apicurio-registry/blob/3.1.x/app/src/main/java/io/apicurio/registry/storage/impl/sql/AbstractSqlRegistryStorage.java#L977-L986

Currently the "name" filter is always a LIKE query rather than an identity query. So maybe we upgrade the SearchFilter to have some context we can use to choose the SQL operator (LIKE vs =).