fix - Fixed notification manager causing hang

AptiviCEO · AptiviCEO · commit 5082d429703a · 2024-12-17T11:07:12.000+03:00
---

We've fixed the notification manager causing hang in the kernel when
trying to shut it down and it fails.

---

Type: fix
Breaking: False
Doc Required: False
Backport Required: False
Part: 1/1
diff --git a/public/Nitrocid/Misc/Notifications/NotificationManager.cs b/public/Nitrocid/Misc/Notifications/NotificationManager.cs
@@ -83,7 +83,9 @@ private static void NotifListen()
                 List<Notification> NewNotificationsList;
                 while (!PowerManager.KernelShutdown)
                 {
-                    SpinWait.SpinUntil(() => sent || dismissing);
+                    SpinWait.SpinUntil(() => sent || dismissing || PowerManager.KernelShutdown);
+                    if (PowerManager.KernelShutdown)
+                        continue;
                     if (dismissing)
                     {
                         dismissing = false;

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,9 @@ private static void NotifListen()`
`83`	`83`	`List<Notification> NewNotificationsList;`
`84`	`84`	`while (!PowerManager.KernelShutdown)`
`85`	`85`	`{`
`86`		`- SpinWait.SpinUntil(() => sent \|\| dismissing);`
	`86`	`+ SpinWait.SpinUntil(() => sent \|\| dismissing \|\| PowerManager.KernelShutdown);`
	`87`	`+ if (PowerManager.KernelShutdown)`
	`88`	`+ continue;`
`87`	`89`	`if (dismissing)`
`88`	`90`	`{`
`89`	`91`	`dismissing = false;`