Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow 'conversational' summary_type with multichannel audio without requiring speaker_labels #71

Open
EnriqueRuvalcaba opened this issue Dec 15, 2024 · 1 comment
Open

Allow 'conversational' summary_type with multichannel audio without requiring speaker_labels #71

EnriqueRuvalcaba opened this issue Dec 15, 2024 · 1 comment
Labels
kind/bug Something isn't working triage/confirmed Issue is well-defined and understood.

Comments

@EnriqueRuvalcaba
Copy link

EnriqueRuvalcaba commented Dec 15, 2024 •
edited
Loading

Allow 'conversational' summary_type with multichannel audio without requiring speaker_labels

Description

The 'conversational' summary type currently requires either speaker_labels or dual_channel to be enabled. However, multichannel is the recommended approach for handling multi-speaker audio, as dual_channel is deprecated.

Current Behavior

{
  multichannel: true,
  summary_type: 'conversational'
  // other options...
}

Throws error: "speaker_labels or dual_channel must be enabled for 'conversational' summaries"

Proposed Change

Update the validation logic to accept multichannel: true as a valid configuration for conversational summaries, since it provides the same speaker separation functionality as the deprecated dual_channel option.
@EnriqueRuvalcaba EnriqueRuvalcaba changed the title Cannot use conversational type summarization when multichannel is true Cannot use conversational type summarization when multichannel is true Dec 15, 2024
@EnriqueRuvalcaba EnriqueRuvalcaba changed the title Cannot use conversational type summarization when multichannel is true Allow 'conversational' summary_type with multichannel audio without requiring speaker_labels Dec 15, 2024
@marcusolsson marcusolsson added kind/bug Something isn't working triage/confirmed Issue is well-defined and understood. labels Jan 7, 2025
@marcusolsson
Copy link
Contributor

Thank you for letting us know! You're right that dual_channel is deprecated and should no longer be required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working triage/confirmed Issue is well-defined and understood.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcusolsson @EnriqueRuvalcaba