You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the bug reported in #1476, while still supporting opts.
Summary: due to when neominimap.nvim looks at the config file, it means that setting the options in config doesn't actually work, instead it must be set during init.
ℹ Additional Information
Minimal test
This is similar to the minimum viable reproducible config, but instead using my version of astrocommunity 😄
-- save as repro.lua-- run with nvim -u repro.lua-- DO NOT change the pathslocalroot=vim.fn.fnamemodify("./.repro", ":p")
-- set stdpaths to use .reprofor_, nameinipairs({ "config", "data", "state", "runtime", "cache" }) dovim.env[("XDG_%s_HOME"):format(name:upper())] =root.."/" ..nameend-- bootstrap lazylocallazypath=root.."/plugins/lazy.nvim"ifnotvim.loop.fs_stat(lazypath) then-- stylua: ignorevim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", "--branch=stable", lazypath })
endvim.opt.rtp:prepend(vim.env.LAZYorlazypath)
-- install pluginslocalplugins= {
{ "AstroNvim/AstroNvim", import="astronvim.plugins" },
{
"AstroNvim/astrocommunity",
{ import="astrocommunity.split-and-window.neominimap-nvim" },
},
{
"Isrothy/neominimap.nvim",
opts= {
layout="split",
split= {
minimap_width=10,
},
},
},
}
require("lazy").setup(plugins, {
root=root.."/plugins",
})
Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:
Proper conventional commit scoping:
If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin
If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error
Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above
README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)
Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).
Proper usage of opts table rather than setting things up with the config function.
Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1476
📑 Description
Fixes the bug reported in #1476, while still supporting
opts.Summary: due to when neominimap.nvim looks at the config file, it means that setting the options in
configdoesn't actually work, instead it must be set duringinit.ℹ Additional Information
Minimal test
This is similar to the minimum viable reproducible config, but instead using my version of astrocommunity 😄