-
Notifications
You must be signed in to change notification settings - Fork 11
Open
Labels
refactorChanges without functional changes, or api changes)Changes without functional changes, or api changes)
Description
Current SIA v3.2 turns on/off based on given configurations, but it has the following probles:
- Easy to make mistakes for developers
- Let's say the following is the correct setting that makes SIA to read local instance cert
this.config.ProviderService === "" && this.config.CertFile === "" && this.config.KeyFile === ""- Developers might forget to include
this.config.CertFile === "" && this.config.KeyFile === ""and only includethis.config.ProviderService === ""- Actually happened and fixed in 27d3522
- Hard to read
- The following code is so vague and has no meaning.
this.config.ProviderService === "" && this.config.CertFile === "" && this.config.KeyFile === ""- if we can have a
DerivedStatethat holds such combination, it would be much easier to read
DerivedState := func() {
if this.config.ProviderService != "" {
return "identityd"
}
if config.CertFile === "" &&config.KeyFile === "" {
return "readLocalFile"
}
return "inactive"
}()WindzCUHK
Metadata
Metadata
Assignees
Labels
refactorChanges without functional changes, or api changes)Changes without functional changes, or api changes)