update test cases ;Signed-off-by: Venkata Bhaskaram Varanasi <[email protected]>

Author: bhaskaramVaranasi

main.go

@@ -125,7 +125,7 @@ func main() {
 	secretName := flag.String("secret-name", "k8s-athenz-syncer", "secret name that contains private key")
 	header := flag.String("auth-header", "", "Authentication header field")
 	nTokenExpireTime := flag.String("ntoken-expiry", "1h0m0s", "Custom nToken expiration duration")
-	excludeNamespaces := flag.String("exclude-namespaces", "", "Namespaces to exclude from processing")
+	excludeNamespaces := flag.String("exclude-namespaces", "", "Namespaces to exclude from processing ex: 'kube-system,kube-public,acceptance-test'")
 
 	klog.InitFlags(nil)
 	flag.Set("logtostderr", "false")
@@ -196,6 +196,7 @@ func main() {
 	excludeNSList := strings.Split(*excludeNamespaces, ",")
 	exclusionList := []string{}
 	for _, item := range excludeNSList {
+		item := strings.TrimSpace(item)
 		if item != "" {
 			exclusionList = append(exclusionList, item)
 		}

pkg/controller/controller_test.go

@@ -19,6 +19,7 @@ import (
 	"context"
 	"crypto/tls"
 	"encoding/json"
+	"fmt"
 	"net"
 	"net/http"
 	"net/http/httptest"
@@ -30,10 +31,12 @@ import (
 	athenz_domain "github.com/AthenZ/k8s-athenz-syncer/pkg/apis/athenz/v1"
 	"github.com/AthenZ/k8s-athenz-syncer/pkg/client/clientset/versioned/fake"
 	"github.com/AthenZ/k8s-athenz-syncer/pkg/cron"
+	"github.com/AthenZ/k8s-athenz-syncer/pkg/log"
 	"github.com/AthenZ/k8s-athenz-syncer/pkg/util"
 	"github.com/ardielle/ardielle-go/rdl"
 	"github.com/google/go-cmp/cmp"
 	k8sfake "k8s.io/client-go/kubernetes/fake"
+	"k8s.io/client-go/util/workqueue"
 )
 
 const (
@@ -204,3 +207,76 @@ func testingHTTPClient(handler http.Handler) (*http.Client, func()) {
 
 	return cli, s.Close
 }
+func TestNsinformerhandler(t *testing.T) {
+	log.InitLogger("/tmp/log/test.log", "info")
+
+	tests := []struct {
+		name             string
+		keyFunc          func(obj interface{}) (string, error)
+		excludedNS       []string
+		expectedResult   string
+		expectedQueueLen int
+		shouldAddToQueue bool
+	}{
+		{
+			name: "Error from key function",
+			keyFunc: func(obj interface{}) (string, error) {
+				return "", fmt.Errorf("mock key function error")
+			},
+			excludedNS:       []string{},
+			expectedResult:   "",
+			expectedQueueLen: 0,
+			shouldAddToQueue: false,
+		},
+		{
+			name: "Excluded namespace",
+			keyFunc: func(obj interface{}) (string, error) {
+				return "test-excluded", nil
+			},
+			excludedNS:       []string{"test-excluded"},
+			expectedResult:   "test-excluded",
+			expectedQueueLen: 0,
+			shouldAddToQueue: false,
+		},
+		{
+			name: "Non-excluded namespace gets added to queue",
+			keyFunc: func(obj interface{}) (string, error) {
+				return "test-namespace", nil
+			},
+			excludedNS:       []string{},
+			expectedResult:   "test-namespace",
+			expectedQueueLen: 1,
+			shouldAddToQueue: true,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			c := newController()
+			c.util = util.NewUtil("admin.domain", []string{"kube-system"}, tt.excludedNS)
+			mockQueue := workqueue.NewRateLimitingQueue(workqueue.DefaultControllerRateLimiter())
+			c.queue = mockQueue
+
+			result := c.nsinformerhandler(tt.keyFunc, &athenz_domain.AthenzDomain{})
+
+			if result != tt.expectedResult {
+				t.Errorf("Expected result '%s', got: '%s'", tt.expectedResult, result)
+			}
+
+			// Sleep to allow item to be queued
+			time.Sleep(2 * time.Second)
+
+			if mockQueue.Len() != tt.expectedQueueLen {
+				t.Errorf("Expected queue length to be %d, got %d", tt.expectedQueueLen, mockQueue.Len())
+			}
+
+			if tt.shouldAddToQueue && mockQueue.Len() > 0 {
+				expectedDomain := c.util.NamespaceToDomain(tt.expectedResult)
+				item, _ := mockQueue.Get()
+				if item != expectedDomain {
+					t.Errorf("Expected %s in queue, got %s", expectedDomain, item)
+				}
+			}
+		})
+	}
+}