Dataresource contacts: Make Public/Primary Contact settings not working

[rosemaryjoconnor]

Issues

1. Make Public flag not functioning: all contacts for dataresources are displaying on public pages regardless of whether the Make Public is checked or not.
2. Primary Contact flag not functioning: If a contact is not set as Primary Contact it is still displaying on public page. Description of this flag seems to indicate that only contacts with Primary Contact set should display.

Testing has been completed in both Test and Production environments with the issues described being consistent in both environments.

Summary of Production testing

Note: all page checks completed:

• not logged in to ALA
• via incognito windows in multiple browsers to eliminate caching issues

Scenario 1

Create new DR with 3 contacts associated. First contact created has Make public set

dr30421: https://collections.ala.org.au/dataResource/show/dr30241
Public Page: https://collections.ala.org.au/public/show/dr30241

Contacts

• Rosemary O'Connor-Editor-Public - editor : Editor with Make public set Primary Contact not set
• Rosemary O'Connor-2-Primary-Public - editor : Editor with Make publicset andPrimary Contact` set
• Rosemary O'Connor-2-Private - editor : Editor with Make Public**not** set andPrimary Contact` not set

Result: all 3 display on the public page

• Based on the descriptions shown when creating these, only Rosemary O'Connor-2-Primary-Public - editor should display on the public page as it is the primary contact. Likely it's ok for both public contacts but a bit confusing if that's not the case and only primary should display.
• Rosemary O'Connor-2-Private - editor should not display at all.

Scenario 2

Create new DR with 1 contact associated with Make Public' not set. Checks that issue was not due to first creating an editor contact with the Make Public` set.

dr30422: https://collections.ala.org.au/dataResource/show/dr30242
Public page: https://collections.ala.org.au/public/show/dr30242

Contacts
Rosemary OConnor-Private - Editor with Make public not set and Primary Contact not set

Result: Contact displays on the public page.

[qifeng-bai]

@rosemaryjoconnor @kylie-m I have a feeling that a non-public contact shouldn’t affect whether it’s displayed on a public data resource page. I’m trying to find someone who can confirm this

[kylie-m]

Thanks Bai, yes, if it's a non-public contact, then their details should not be displayed on a public page

(ie they want their details to remain private, so we keep them private)

[vjrj]

Hi I have some pull request as draft trying to improve many things in the contacts parsing, and I can try to fix this too at the same time. I adding tests to this repository, so it will easy to test it too:
#260

But I have an important doubt about how to do it described here:
#260 (comment)
basically if we should link Contacts of different DRs or not (as GBIF does).

[rosemaryjoconnor]

Thanks Bai. As per Kylie - any contacts that indicate they are private/non-public do not want to be displayed on any public page.

[qifeng-bai]

Thanks for the comment. We’ll take a look and get back to you soon. @vjrj @adam-collins