Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom associations for PSI icons #224

Open
mallowigi opened this issue Sep 29, 2021 · 7 comments
Open

Custom associations for PSI icons #224

mallowigi opened this issue Sep 29, 2021 · 7 comments

Comments

@mallowigi
Copy link
Collaborator

This would be harder to do but needs to be done nonetheless

@stale
Copy link

stale bot commented Dec 19, 2021

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 19, 2021
@stale
Copy link

stale bot commented Jan 18, 2022

This PR has been automatically closed because it has not had recent activity. You can reopen it by clicking on Reopen pull request. Thank you for your contributions.

@stale stale bot closed this as completed Jan 18, 2022
@mallowigi mallowigi reopened this Jan 18, 2022
@stale stale bot removed the stale label Jan 18, 2022
@mallowigi mallowigi added the WIP label Jan 18, 2022
@undermark5
Copy link

It would be awesome if there were an option to disable the PSI icons, but fallback to the the filetype association icons.

@mallowigi
Copy link
Collaborator Author

I think it's possible to do via a custom association, which will have the effect of overriding the .java/.php/.kotlin etc icons with your own

@undermark5
Copy link

I don't believe that it is unless I'm doing something wrong, I've configured a "custom" file association (basically just a duplicate of the one of interest), and disabled the PSI icons and the custom type doesn't apply to the files in question (they show the default PSI icon). Also doesn't apply with the PSI icons enabled either.

My main reason for my request above is because I don't particularly care for the PSI icons, but disabling them leaves the icons a mismatched grouping. I believe it has something to do with the fact that the PSI system ends up treating those files differently, and there isn't a way to override the PSI icons used in which situation, however, I believe that the PSI is either aware of the Language association or the file extension because the default Kotlin PSI icons have a Kotlin logo in the lower right whereas the Java ones don't.

Custom PSI associations would solve the issue entirely as I could apply it to all Kotlin language files to show the kotlin icon rather than the associated PSI Class/Interface/Enum icons

@mallowigi
Copy link
Collaborator Author

I suspected it would be the case because of a historic issue where the file associations for php were overriding the psi icons, and a similar issue with Groovy and Kotlin, so I suspect these would work but I'm not sure.

@mallowigi
Copy link
Collaborator Author

Cross that. I remember that I added an exclusion for these associations. That might be why it didn't have an effect for you.

That demands more digging. I suppose you can try it by yourself if you're courageous enough to clone the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants