Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new icons set from Material Design 2/3 (Outlined, Dual tone, Round, ...) #293

Open
maicol07 opened this issue Jun 1, 2022 · 6 comments

Comments

@maicol07
Copy link

maicol07 commented Jun 1, 2022

Is your feature request related to a problem? Please describe.
While Material Theme UI has been revamped with Material Design 2, icons are still the same

Describe the solution you'd like
New sets of icons that can be chosen with a setting

Describe alternatives you've considered
None

@mallowigi
Copy link
Collaborator

Hmmmmmmmmmm while this is a good idea, this would bloat up the package a lot... besides outlined icons are not for all icons, aren't they?

Can you provide more information about what you're referring to?

@maicol07
Copy link
Author

maicol07 commented Jun 2, 2022

Yeah, some outlined icons don't exist. Simply that icon will fallback to the default Material one. I recommend materialdesignicons.com or Icons8 to look for icons since they got much more icons than the standard Google set.

I have two ideas to avoid to bloat up the plugin:

  1. Provide optional plugin to add more icons variant (although I don't know if it's possible to get plugins interact each other)
  2. Allow users to add icon sets to a specific folder(s) and allow users to switch the icons through a setting.

It would be great if standard icon sets (outlined, filled, round, sharp, dual tone, ...) can be provided with the plugin release (i.e. from Github releases)

@stale
Copy link

stale bot commented Jun 17, 2022

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 17, 2022
@maicol07
Copy link
Author

@mallowigi what do yout think?

@stale stale bot removed the stale label Jun 25, 2022
@mallowigi
Copy link
Collaborator

This will have to wait. Currently we have a big hurdle is that there is no way to control the PSI and UI Icons. These are replaced using the concept of "patchers", but they are on a "per-plugin level" (e.g. replace the path) rather than on a "per icon level" (replace the icon).

One big refactor that I'll have to do at some point would be to add both. This would allow both custom associations and whatever you are recommending.

But this will happen way, way later. (That is unless you want to dirty your hands :))

@stale
Copy link

stale bot commented Jul 9, 2022

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants