-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new icons set from Material Design 2/3 (Outlined, Dual tone, Round, ...) #293
Comments
Hmmmmmmmmmm while this is a good idea, this would bloat up the package a lot... besides outlined icons are not for all icons, aren't they? Can you provide more information about what you're referring to? |
Yeah, some outlined icons don't exist. Simply that icon will fallback to the default Material one. I recommend materialdesignicons.com or Icons8 to look for icons since they got much more icons than the standard Google set. I have two ideas to avoid to bloat up the plugin:
It would be great if standard icon sets (outlined, filled, round, sharp, dual tone, ...) can be provided with the plugin release (i.e. from Github releases) |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@mallowigi what do yout think? |
This will have to wait. Currently we have a big hurdle is that there is no way to control the PSI and UI Icons. These are replaced using the concept of "patchers", but they are on a "per-plugin level" (e.g. replace the path) rather than on a "per icon level" (replace the icon). One big refactor that I'll have to do at some point would be to add both. This would allow both custom associations and whatever you are recommending. But this will happen way, way later. (That is unless you want to dirty your hands :)) |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Is your feature request related to a problem? Please describe.
While Material Theme UI has been revamped with Material Design 2, icons are still the same
Describe the solution you'd like
New sets of icons that can be chosen with a setting
Describe alternatives you've considered
None
The text was updated successfully, but these errors were encountered: