Resizing icons in toolbar?

[adamwfennell]

Hello,

I was just wondering if there are any settings to resize the icons in the toolbar? It appears there are for e.g. font sizes, etc. but not for the icons?

Many thanks,
Adam

[hbitteur]

Good idea.
Should not be very difficult.

[adamwfennell]

Great - thanks! I couldn't work out where in the code the icons are actually loaded in. Could you point me in the right direction, please?

[hbitteur]

It's like a treasure hunt :-)

All UI actions are defined by the file app/res/system-actions.xml, which begins like this:

<actions>
    
    <action domain="FILE" section="10" class="org.audiveris.omr.sheet.ui.BookActions" menu="inputHistory"           button="javax.swing.JButton"/>
    <action domain="FILE" section="10" class="org.audiveris.omr.sheet.ui.BookActions" method="openImageFiles"        button="javax.swing.JButton"/>
    <action domain="FILE" section="70" class="org.audiveris.omr.ui.GuiActions"        method="exit"/>

FYI, this mechanism is implemented by the class org/audiveris/omr/ui/action/ActionManager.java.

For instance, the second line defines the action "openImageFiles", implemented in the Java class org.audiveris.omr.sheet.ui.BookActions.java by the method of the same name:

    //----------------//
    // openImageFiles //
    //----------------//
    /**
     * Action that let the user select one or several image files interactively.
     *
     * @param e the event that triggered this action
     * @return the asynchronous task, or null
     */
    @Action
    public LoadFilesTask openImageFiles (ActionEvent e)
    {
        final Path[] paths = selectImagePaths();

        if (paths.length > 0) {
            return new LoadFilesTask(Arrays.asList(paths));
        }

        return null;
    }

This openImageFiles method is annotated by the @Action tag.
This means that all the attached information, such as the localized action name and the related icon, can be found in the corresponding file org.audiveris.omr.sheet.ui.resources.BookActions.properties located in the sibling resources source folder.

Here is an excerpt of this file:

openImageFiles.Action.text = &Input...
openImageFiles.Action.shortDescription = Open image files
openImageFiles.Action.icon = ${icons.root}/filesystems/folder_images.png
openImageFiles.Action.accelerator = control O

As we can see, the action details are described here, including the icon reference.
icons.root is a logical name, defined in app/src/main/java/org/audiveris/omr/ui/resources/MainGui.properties:

# Reference to selected Crystal icons
icons.root = /crystal/22x22

During the build process (driven by the file app/build.gradle), the content of dev/icons is copied to Audiveris binary root,
thus making the icons available at runtime under the /crystal/22x22 folder, and resulting in this user interface:

Now where do these icons come from?
I copied them manually from this django-crystal-small github page available under LGPL license, as commented in Audiveris dependencies section.
Note the icons there exist in various sizes (16x16, 22x22, 24x24, 32x32 and 48x48).

We could easily choose a icon size larger than the current 22x22.

Now, this would be a static modification, the same for all users. And I suppose you would like the ability for any end user to choose the font size. I will leave this question open for now.

[hbitteur]

In case you wonder, all this machinery is the Swing Application Framework, described in https://www.oracle.com/technical-resources/articles/javase/swingappfr.html.

[hbitteur]

I just discovered by reading the source code of the ApplicationAction class in BSAF that we can define several icons for a given action.

For instance, instead of:

openImageFiles.Action.icon = ${icons.root}/filesystems/folder_images.png

we could have:

openImageFiles.Action.smallIcon = path/to/small/image.png
openImageFiles.Action.largeIcon = path/to/large/image.png

By default, the larger icon is used for the buttons on the task bar and the smaller for the menu items.

Would this fit your needs?

[hbitteur]

I will soon push a commit on development branch that addresses the small/large icons

[adamwfennell]

Thank you! Apologies, for the delayed response - been very busy lately!

Yes, this all sounds good!

Thanks again,
Adam

[Etsi-o]

This is really great!
Would it be possible to have the default scaling be dependent on the screen size or system settings? This would help people not needing to navigate and modify this?
I also found some issues in some of the settings when changing the font scaling, with the text fields not accommodating the new text size.

[hbitteur]

@adamwfennell
This is really ugly!
Let me investigate.

[hbitteur]

@adamwfennell

Done. See commit 4e85131 on the development branch.
Let me tell you I suffered hours and hours on the Preferences dialog! For the Constants dialog, this was really easy.

The changes are driven by the user changing the font size (in the Preferences dialog). Of course, you need to restart the application.

Second point: "In theory", a change in system settings (or perhaps screen size) should be transparently processed, since all sizing values in the Preferences dialog are stated in "DLU", not in physical pixels.
Please let me know if this really works.