Out of Core Examples #142
Merged
Out of Core Examples #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Chorus detected one or more security issues with this pull request. See the Checks tab for more details. As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement. |
loliverhennigh
commented
Sep 10, 2025
|
|
||
| # Remove indices from BC objects | ||
| bc.__dict__.pop("indices", None) | ||
| #bc.__dict__.pop("indices", None) |
There was a problem hiding this comment.
I need to call this multiple times for so cant delete the indices.
loliverhennigh
commented
Sep 10, 2025
| #} | ||
|
|
||
| # Compute strain | ||
| strain = wp.float32(0.0) |
There was a problem hiding this comment.
This could be an incorrect implementation. It seems very stable and I dont notice too many differences with KBC though.
|
Thanks @loliverhennigh. We decided to merge the PR as is, and then handle the integration in follow-up PRs, since doing it through comments would be too slow. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing Guidelines
Description
Type of change
How Has This Been Tested?
Linting and Code Formatting
Make sure the code follows the project's linting and formatting standards. This project uses Ruff for linting.
To run Ruff, execute the following command from the root of the repository:
ruff check .