-
Notifications
You must be signed in to change notification settings - Fork 312
Description
After the release of Simplenote 2.33 and the edge-to-edge changes in #1737, there are some interface issues with the authentication screens. See the screenshots and video below for illustration.
Video
1742_authentication_screens_issues.mp4
Accessibility
The first Log In screen with the Log In With... buttons has the following accessibility issues:
- Log In With Email button color contrast between background and text is too low.
- Log In Manually text button height is less than minimum touch target size.
- Log In Manually text button has no touch feedback.
Clipping
The first Log In screen with the Log In With... buttons clips the bottom button in landscape orientation. Depending on the height of the device, that can make the button height smaller than the minimum required 48dp too.
Overlapping
Both the Log In and Sign Up screens overlap the system bars and display cutouts.
Touching
On the Enter Code screen for magic link login, touches pass through the visible elements to invisible elements behind.
Expected
Accessibility standards are followed. Interactive elements are not clipped. Interfaces do not overlap system bars. Touches do not pass through.
Observed
Accessibility standards are not followed. Interactive elements are clipped. Interfaces do overlap system bars. Touches do pass through.
Reproduced
Follow the steps below with simplenote-android-prototype-build-pr1737-dd575ff-01987b6b-2ce1-4d17-8edf-4e50efdd3568.apk
on a device with a display cutout (e.g. Pixel 9) and three-button navigation enabled.
- Rotate device into landscape orientation.
- Tap Sign Up button.
- Notice interface overlaps display cutout.
- Tap back arrow in top app bar.
- Tap Log In button.
- Notice interface overlaps display cutout.
- Notice Log In With Email button color contrast.
- Notice Log In With WordPress.com button is clipped.
- Long-press Log In Manually text button.
- Notice no touch feedback.
- Tap Log In Manually text button.
- Notice interface overlaps navigation bar, status bar, and display cutout.
- Notice password visibility toggle shows visible icon.
- Tap back arrow in top app bar.
- Tap Log In button.
- Enter address of existing account in Email field.
- Tap Log In With Email button.
- Notice Enter Code is shown.
- Tap "We've sent a code to..." text.
- Notice text field cursor is shown.
- Press Tab on keyboard repeatedly.
- Notice keyboard changes when invisible elements are focused.
Device Make: Google
Device Model: Pixel 9
Android Version: 16.0.0
Simplenote Version: 2.35.0