Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP-CLI: Should there be a time limit? #440

Closed
joshbetz opened this issue Jul 25, 2019 · 1 comment
Closed

WP-CLI: Should there be a time limit? #440

joshbetz opened this issue Jul 25, 2019 · 1 comment

Comments

@joshbetz
Copy link
Contributor

Should commands be allowed to run for an unlimited amount of time? If so, we can close this. Otherwise we need to keep track of how long a command has been running for and cancel it after some timeout. We can test with the following command:

WP_CLI::add_command( 'test memory', function() {
    while( true ) {
        WP_CLI::line( sprintf( '%d minutes', $i++ ) );
        sleep( 60 );
    }
} );

We probably want any timeout to be pretty long, but actually letting things run forever is sub-optimal.

Related: #361

@joshbetz joshbetz added the [Type] Question Extra attention is needed label Jul 25, 2019
@github-actions
Copy link
Contributor

This issue has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed.

This is an automation to keep issues manageable and actionable and is not a comment on the quality of this issue nor on the work done so far. Closed issues are still valuable to the project and are available to be searched.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant