Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Test Data site: Host or upload images to Github #90054

Closed
jp-imagines opened this issue Apr 29, 2024 · 2 comments
Closed

Theme Test Data site: Host or upload images to Github #90054

jp-imagines opened this issue Apr 29, 2024 · 2 comments
Labels
[Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. [Feature] Managed Plugins & Themes Plugins and themes controlled by Automattic for Atomic sites. [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Feature Request Feature requests

Comments

@jp-imagines
Copy link

What

See WordPress/wordpress-playground#718 (comment) and WordPress/theme-test-data#82 (comment) for more details.

Media files on wpthemetestdata.wordpress.com are hosted on WordPress.com, i.e. wpthemetestdata.files.wordpress.com. CORS errors prevent these images from being imported into WordPress Playground sites.

It has been proposed that the media files be hosted on or uploaded to Github to bypass CORS errors.

Why

To allow this site's setup – including media files – to be used as a default option for testing themes in Playground.

How

Possible options:

  1. Upload all images from wpthemetestdata.wordpress.com to Github and update the site to use these externally-hosted images and regenerate a new XML export file.
  2. Provide a ZIP of all images on the site which can then be uploaded to Github by anyone. Media file references can then be updated in the existing XML file in the https://github.com/WordPress/theme-test-data/ repo.
  3. Update references in the existing XML file to use i*.wp.com CDN URLs instead of *.files.wordpress.com URLs.
@jp-imagines jp-imagines added [Type] Feature Request Feature requests [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. [Feature] Managed Plugins & Themes Plugins and themes controlled by Automattic for Atomic sites. labels Apr 29, 2024
@mrfoxtalbot mrfoxtalbot moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Apr 30, 2024
@flexseth
Copy link

flexseth commented May 2, 2024

@jp-imagines thanks for taking a look at this!

@jp-imagines
Copy link
Author

@flexseth I spoke to a few colleagues about this, all of whom agreed with the recommendations from here: WordPress/theme-test-data#82 (comment)

Looks like a fix is already in the works in WordPress/theme-test-data#89 (using i*.wp.com CDN URLs), and the other solution would be to just download some or all of the media files from the test site and upload them to Github instead.

I'll close out this issue in light of that open PR and the discussions in the WP repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. [Feature] Managed Plugins & Themes Plugins and themes controlled by Automattic for Atomic sites. [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Feature Request Feature requests
Development

No branches or pull requests

2 participants