Retain selected tab when domain is switched

[Imran92]

In our new flyout view, when domain is switched, we open the default tab, that is the domain overview tab. So even if we are currently on the Emails tab, if we switch domains, the Overview will be opened for the new domain. Then we'll need to switch to the Emails tab.

Similar to how wordpress.com/sites work, we want to open the same tab when domains are switched

[github-actions]

OpenAI suggested the following labels for this issue:

• [Feature Group] Emails & Domains: The issue is related to switching domains and retaining the selected tab, which falls under domain management and email functionalities.
• [Feature] Domain Management: This specifically addresses the management of domains, which is directly relevant to the context of switching domains in the issue.
• [Feature] Site Navigation: The issue discusses user navigation between tabs, particularly retaining the current tab during domain switching, which is related to site navigation features.

[donnapep]

@Imran92 I've been digging into the details of the Domains dashboard and how info gets passed around in order to try to fix this one. Looking at how the Sites dashboard does it, I think this will be easier to implement and require less rework once DataViews are already in place. Any objection to moving this one to Blocked for the time being?

Please let me know if I've missed something or if you already had an idea of how to solve this in a simpler way. Thx!

[donnapep]

For kicks, I checked out the draft DataViews branch and tried to fix this there, but it looks like the list of domains in the sidebar is still using the old structure (i.e. <a> elements with hardcoded href attributes instead of <span> tags).

[Imran92]

Thanks for diggint deeper into it @donnapep! You're totally right, it makes sense to wait until the DataViews conversion is done to avoid rework. I put together a quick POC here: #97710 with a very simple version of it. It's just a rough draft and also doesn’t handle subpages yet.

Though, I actually think we shouldn't worry about retaining subpages even in the future either since not all domains have all of them, so it won't be a 1:1 map for each domain, and it could make things unnecessarily complicated. Instead, we could just pick the email tab when we can surely detect, and fall back to the overview tab as the default.

Also, I used window.location.pathname in the POC, but we could switch to using the existing withCurrentRoute HOC or useCurrentRoute hook later if we want—it’s probably cleaner. But I don’t think it’s a blocker at all. Totally okay to do it later as an improvement.

Let me know what you think!

[donnapep]

Putting this back in Doing as I see a potential solution now.

[donnapep]

@Imran92 Turns out I'm not totally right. 😆 There is a relatively simple way to do it as per #97719. I'll need to hand this one off to someone else on the team though as I'm going AFK and there are still a few TODOs.