Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Migration: Show the correct landing page when users ask for help #98092

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

gabrielcaires
Copy link
Contributor

@gabrielcaires gabrielcaires commented Jan 8, 2025

Closes #97664

Proposed Changes

  • Move the user to the SITE_MIGRATION_SUPPORT_INSTRUCTIONS step when they ask if the platform is not supported and ask for help.
  • Create a help ticket when the user clicks the support instructions step.

Why are these changes being made?

  • As described in the original ticket, nowadays, when the user asks for help, we redirect the user to the regular SITE_MIGRATION_ASSISTED_MIGRATION, which says the migration will happen and also marks the migration as started.

Screenshots

image

Testing Instructions

  • Go to any of the migration flows (e.g /setup/hosted-site-migration)
  • Follow all steps by choosing the DIFM until the Tell us about your WordPress site
  • Set any non-WordPress site
  • On the Looks like there's been a mix-up step, click Looks like there's been a mix-up
  • Check if you can see the migration-support-instructions step
  • Check if a ticket was created (http call to /help/migration-ticket/new

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@gabrielcaires gabrielcaires requested a review from a team January 8, 2025 16:41
@gabrielcaires gabrielcaires self-assigned this Jan 8, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 8, 2025
@gabrielcaires gabrielcaires added the [Feature] Site Migration Features related to site migrations to WPcom label Jan 8, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/landing-page-when-user-ask-for-help on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~18 bytes added 📈 [gzipped])

name                        parsed_size           gzip_size
import-hosted-site-flow          +304 B  (+0.0%)      +16 B  (+0.0%)
site-migration-flow               +42 B  (+0.1%)       +2 B  (+0.0%)
hosted-site-migration-flow        +42 B  (+0.1%)       +2 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@@ -9,8 +11,8 @@ import { useSelector } from 'calypso/state';
import { getCurrentUser } from 'calypso/state/current-user/selectors';
import FlowCard from '../components/flow-card';
import { redirect } from '../import/util';
import { useSubmitMigrationTicket } from '../importer-migrate-message/hooks/use-submit-migration-ticket';
Copy link
Contributor

@andres-blanco andres-blanco Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we extract this hook to a more general location? we might end up using it in different contexts, for example: p1737039155741989-slack-C0Q664T29

Copy link
Contributor

@andres-blanco andres-blanco Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be tackled in a new PR so we can submit the fix faster.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #98502

Copy link
Contributor

@andres-blanco andres-blanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielcaires gabrielcaires merged commit 58f2dfa into trunk Jan 16, 2025
13 checks passed
@gabrielcaires gabrielcaires deleted the fix/landing-page-when-user-ask-for-help branch January 16, 2025 20:21
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 16, 2025
@gabrielcaires gabrielcaires changed the title Site Migration: Show correct landing page when user ask for help Site Migration: Show the correct landing page when users ask for help Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Site Migration [Feature] Site Migration Features related to site migrations to WPcom
Projects
None yet
3 participants