-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Migration: Show the correct landing page when users ask for help #98092
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~18 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@@ -9,8 +11,8 @@ import { useSelector } from 'calypso/state'; | |||
import { getCurrentUser } from 'calypso/state/current-user/selectors'; | |||
import FlowCard from '../components/flow-card'; | |||
import { redirect } from '../import/util'; | |||
import { useSubmitMigrationTicket } from '../importer-migrate-message/hooks/use-submit-migration-ticket'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we extract this hook to a more general location? we might end up using it in different contexts, for example: p1737039155741989-slack-C0Q664T29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be tackled in a new PR so we can submit the fix faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR #98502
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #97664
Proposed Changes
Why are these changes being made?
Screenshots
Testing Instructions
Tell us about your WordPress site
Looks like there's been a mix-up
step, clickLooks like there's been a mix-up
migration-support-instructions
step/help/migration-ticket/new
Pre-merge Checklist