Alarm icon disappears from header unexpectedly

[mtbu]

The alarm icon in the header/panel on the top appears to be driven by whether there are upcoming alarms for the month/day selected in the calendar view, not today. This feels wrong; I'd expect the header to remain unchanged, and only the rest of the indicator menu to update when selecting days in the calendar view.

I guess this might be related to the update_upcoming() and update_header() functions in src/menu.cpp

(Running UBports 20.04 development, version r45, on FP3 device).

To reproduce:

1. Have a recurring alarm set for every day.
2. Open indicator menu, observe the alarm icon is shown in the header.
3. Select a date in the calendar which is in the future. The alarm icon will still be present, since there are alarms for that day.
4. Select a date in the calendar which is in the past. The alarms (as I would expect) are no longer shown in the indicator menu below the calendar. The alarm icon disappears and is replaced by the current time.
5. Swipe up to close the indicator menu. The alarm icon is still not present.
6. Reopen the indicator menu. The calendar will reset to the current day, the indicator will realise there is an alarm, and re-show the alarm icon.