Skip to content

Commit e7af503

Browse files
committed
Allow ACA to configure secrets with identity and keyvaultUrl properties
1 parent a6b2b83 commit e7af503

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

tests/test_cookiecutter_generation.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def tests_valid_bicep(bakery):
6464
)
6565
)
6666
result = subprocess.run(commands, capture_output=True, text=True)
67-
assert result.returncode == 0
67+
assert result.returncode == 0, result.stderr
6868

6969
@pytest.mark.skip(reason="not implmented yet")
7070
def tests_mongo_builds_use_mongo_db_vars(bakery, default_context):

{{cookiecutter.__src_folder_name}}/infra/aca.bicep

+11-13
Original file line numberDiff line numberDiff line change
@@ -100,23 +100,21 @@ module app 'core/host/container-app-upsert.bicep' = {
100100
]
101101
secrets: {
102102
{% if cookiecutter.db_resource in ("postgres-flexible", "cosmos-postgres") %}
103-
{
104-
'dbserver-password': dbserverPassword
105-
}
103+
'dbserver-password': {
104+
value: dbserverPassword
105+
}
106106
{% endif %}
107107
{% if cookiecutter.project_backend in ("django", "flask") %}
108-
{
109-
name: 'secret-key'
110-
keyVaultUrl: '${keyVault.properties.vaultUri}secrets/SECRETKEY'
111-
identity: webIdentity.id
112-
}
108+
'secret-key': {
109+
keyVaultUrl: '${keyVault.properties.vaultUri}secrets/SECRETKEY'
110+
identity: webIdentity.id
111+
}
113112
{% endif %}
114113
{% if "mongodb" in cookiecutter.db_resource %}
115-
{
116-
name: 'azure-cosmos-connection-string'
117-
keyVaultUrl: '${keyVault.properties.vaultUri}secrets/AZURE-COSMOS-CONNECTION-STRING'
118-
identity: webIdentity.id
119-
}
114+
'azure-cosmos-connection-string': {
115+
keyVaultUrl: '${keyVault.properties.vaultUri}secrets/AZURE-COSMOS-CONNECTION-STRING'
116+
identity: webIdentity.id
117+
}
120118
{% endif %}
121119
}
122120
{% if cookiecutter.db_resource == "postgres-addon" %}

{{cookiecutter.__src_folder_name}}/infra/core/host/container-app.bicep

+3-1
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,9 @@ resource app 'Microsoft.App/containerApps@2023-05-02-preview' = {
130130
} : { enabled: false }
131131
secrets: [for secret in items(secrets): {
132132
name: secret.key
133-
value: secret.value
133+
value: secret.value.value
134+
keyVaultUrl: secret.value.keyVault
135+
identity: secret.value.identity
134136
}]
135137
service: !empty(serviceType) ? { type: serviceType } : null
136138
registries: usePrivateRegistry ? [

0 commit comments

Comments
 (0)