Skip to content

Commit b26c60d

Browse files
committed
Update ProductVo -> ProductValueObject
1 parent 459c80c commit b26c60d

File tree

5 files changed

+31
-31
lines changed

5 files changed

+31
-31
lines changed

apps/acme-catalog/src/main/java/com/example/acme/catalog/GetProductResponse.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,19 @@
22

33
public class GetProductResponse {
44

5-
private ProductVo data;
5+
private ProductValueObject data;
66
private int status;
77

8-
public GetProductResponse(ProductVo data, int status) {
8+
public GetProductResponse(ProductValueObject data, int status) {
99
this.data = data;
1010
this.status = status;
1111
}
1212

13-
public ProductVo getData() {
13+
public ProductValueObject getData() {
1414
return data;
1515
}
1616

17-
public void setData(ProductVo data) {
17+
public void setData(ProductValueObject data) {
1818
this.data = data;
1919
}
2020

apps/acme-catalog/src/main/java/com/example/acme/catalog/GetProductsResponse.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,17 @@
44

55
public class GetProductsResponse {
66

7-
private List<ProductVo> data;
7+
private List<ProductValueObject> data;
88

9-
public GetProductsResponse(List<ProductVo> data) {
9+
public GetProductsResponse(List<ProductValueObject> data) {
1010
this.data = data;
1111
}
1212

13-
public List<ProductVo> getData() {
13+
public List<ProductValueObject> getData() {
1414
return data;
1515
}
1616

17-
public void setData(List<ProductVo> data) {
17+
public void setData(List<ProductValueObject> data) {
1818
this.data = data;
1919
}
2020
}

apps/acme-catalog/src/main/java/com/example/acme/catalog/Product.java

+12-12
Original file line numberDiff line numberDiff line change
@@ -28,24 +28,24 @@ public class Product {
2828
private Double price;
2929
private String tags;
3030

31-
public static Product fromProductRequestToProduct(ProductVo productVo) {
31+
public static Product fromProductRequestToProduct(ProductValueObject productVO) {
3232

3333
Product product = new Product();
34-
product.setPrice(productVo.getPrice());
35-
product.setDescription(productVo.getDescription());
36-
product.setName(productVo.getName());
37-
product.setImageUrl1(productVo.getImageUrl1());
38-
product.setImageUrl2(productVo.getImageUrl2());
39-
product.setImageUrl3(productVo.getImageUrl3());
40-
product.setShortDescription(productVo.getShortDescription());
34+
product.setPrice(productVO.getPrice());
35+
product.setDescription(productVO.getDescription());
36+
product.setName(productVO.getName());
37+
product.setImageUrl1(productVO.getImageUrl1());
38+
product.setImageUrl2(productVO.getImageUrl2());
39+
product.setImageUrl3(productVO.getImageUrl3());
40+
product.setShortDescription(productVO.getShortDescription());
4141

4242
String tags = null;
4343

44-
if (productVo.getTags() != null && !productVo.getTags().isEmpty()) {
44+
if (productVO.getTags() != null && !productVO.getTags().isEmpty()) {
4545
tags = "";
46-
for (int i = 0; i < productVo.getTags().size(); i++) {
47-
tags = tags + productVo.getTags().get(i);
48-
if (i < productVo.getTags().size() - 1) {
46+
for (int i = 0; i < productVO.getTags().size(); i++) {
47+
tags = tags + productVO.getTags().get(i);
48+
if (i < productVO.getTags().size() - 1) {
4949
tags = tags + ",";
5050
}
5151
}

apps/acme-catalog/src/main/java/com/example/acme/catalog/ProductController.java

+8-8
Original file line numberDiff line numberDiff line change
@@ -25,25 +25,25 @@ public ProductController(ProductService productService) {
2525
@GetMapping("/products")
2626
public GetProductsResponse getProducts() {
2727
return new GetProductsResponse(productService.getProducts().stream()
28-
.map(ProductVo::new)
28+
.map(ProductValueObject::new)
2929
.collect(Collectors.toList()));
3030
}
3131

3232
@GetMapping("/products/{id}")
3333
public GetProductResponse getProduct(@PathVariable String id) {
34-
return new GetProductResponse(new ProductVo(productService.getProduct(id)), HttpStatus.OK.value());
34+
return new GetProductResponse(new ProductValueObject(productService.getProduct(id)), HttpStatus.OK.value());
3535
}
3636

3737
@PostMapping("/products")
38-
public ResponseEntity<ProductVo> createProduct(@RequestBody ProductVo productVo) {
39-
Product product = productService.createProduct(Product.fromProductRequestToProduct(productVo));
40-
return ResponseEntity.ok(new ProductVo(product));
38+
public ResponseEntity<ProductValueObject> createProduct(@RequestBody ProductValueObject productVO) {
39+
Product product = productService.createProduct(Product.fromProductRequestToProduct(productVO));
40+
return ResponseEntity.ok(new ProductValueObject(product));
4141
}
4242

4343
@PostMapping("/products/{id}")
44-
public ResponseEntity<ProductVo> updateProduct(@PathVariable String id, @RequestBody ProductVo productVo) {
45-
Product product = productService.updateProduct(id, Product.fromProductRequestToProduct(productVo));
46-
return ResponseEntity.ok(new ProductVo(product));
44+
public ResponseEntity<ProductValueObject> updateProduct(@PathVariable String id, @RequestBody ProductValueObject productVO) {
45+
Product product = productService.updateProduct(id, Product.fromProductRequestToProduct(productVO));
46+
return ResponseEntity.ok(new ProductValueObject(product));
4747
}
4848

4949
@DeleteMapping("/products/{id}")

apps/acme-catalog/src/main/java/com/example/acme/catalog/ProductVo.java apps/acme-catalog/src/main/java/com/example/acme/catalog/ProductValueObject.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
import org.springframework.util.StringUtils;
88

9-
public class ProductVo {
9+
public class ProductValueObject {
1010

1111
private String id;
1212
private String imageUrl1;
@@ -18,10 +18,10 @@ public class ProductVo {
1818
private Double price;
1919
private List<String> tags = new ArrayList<>();
2020

21-
public ProductVo() {
21+
public ProductValueObject() {
2222
}
2323

24-
public ProductVo(Product product) {
24+
public ProductValueObject(Product product) {
2525
id = product.getId();
2626
price = product.getPrice();
2727
description = product.getDescription();

0 commit comments

Comments
 (0)