Skip to content

Commit 2b1e8a0

Browse files
authored
fixed monitoring (#8)
- fixed dashboards - fixed monitoring setup parameters that were mixed up - removed version for cli extension
1 parent ea5e5e9 commit 2b1e8a0

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

.github/workflows/build-monitoring.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,6 @@ jobs:
4444
az provider register --namespace Microsoft.AlertsManagement --wait
4545
az extension add --name amg
4646
- name: Create Azure Monitor and Grafana resources
47-
run: bash ${GITHUB_WORKSPACE}/scripts/configure-azmon-grafana.sh -v $vmName -g $resourceGroup -m $monitorName -d $grafanaName -c $clusterName
47+
run: bash ${GITHUB_WORKSPACE}/scripts/configure-azmon-grafana.sh -g $resourceGroup -m $monitorName -d $grafanaName -c $clusterName
4848
- name: Configure hostmemusage collection
49-
run: bash ${GITHUB_WORKSPACE}/scripts/configure-vm-hostmemusage-collector.sh -g $resourceGroup -l $logAnalytics -m $monitorName
49+
run: bash ${GITHUB_WORKSPACE}/scripts/configure-vm-hostmemusage-collector.sh -v $vmName -g $resourceGroup -l $logAnalytics -m $monitorName

.github/workflows/build-vm.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ jobs:
194194
--settings "{\"commandToExecute\":\"powershell q -Confirm:\$false; \
195195
kubectl get pods -A -v6 --kubeconfig C:\\scripts\\config; \
196196
az login --identity; \
197-
az extension add --name connectedk8s --version 1.6.0; \
197+
az extension add --name connectedk8s; \
198198
az extension add --name azure-iot-ops; \
199199
az connectedk8s connect --debug -n $clusterName -l $location -g $resourceGroup --kube-config C:\\Scripts\\config --subscription $subscriptionId; \
200200
Remove-Item -LiteralPath C:\\Windows\\System32\\config\\systemprofile\\.azure\\AzureArcCharts -Recurse -Force; \
@@ -217,7 +217,7 @@ jobs:
217217
kubectl get pods -A -v6 && \
218218
decodedSecret=\$(echo $encodedBase64Secret | base64 -d) && \
219219
az login --service-principal -u ${{ secrets.AZURE_SP_CLIENT_ID }} -p \"\"\$decodedSecret\"\" --tenant $tenantId && \
220-
az extension add --name connectedk8s --version 1.6.0 && \
220+
az extension add --name connectedk8s && \
221221
az extension add --name azure-iot-ops && \
222222
az connectedk8s connect --debug -n $clusterName -l $location -g $resourceGroup --subscription $subscriptionId && \
223223
az connectedk8s enable-features --debug -n $clusterName -g $resourceGroup --custom-locations-oid \"\"${{ secrets.CUSTOM_LOCATIONS_OBJECT_ID }}\"\" --features cluster-connect custom-locations && \

scripts/configure-vm-hostmemusage-collector.sh

+3-1
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,12 @@ else
6969
echo "Grafana resource ($grafanaName) found. Use existing..."
7070
fi
7171

72-
hostDashboardName="Memory Footprint - Host"
7372
allDashboardName="Memory Footprint"
73+
hostDashboardName="Memory Footprint - Host"
7474
echo "Creating grafana dashboard..."
75+
sed -i "s/##SUBSCRIPTION_ID##/$subscriptionId/g" monitoring/mem_by_all.json
7576
sed -i "s/##SUBSCRIPTION_ID##/$subscriptionId/g" monitoring/mem_by_proc.json
77+
sed -i "s/##RESOURCE_GROUP##/$resourceGroup/g" monitoring/mem_by_all.json
7678
sed -i "s/##RESOURCE_GROUP##/$resourceGroup/g" monitoring/mem_by_proc.json
7779
if [ $osType == "Linux" ]; then
7880
ts_query='CgroupMem_CL\\r\\n| where $__timeFilter(TimeGenerated)\\r\\n| summarize Memory=sum(MemoryUsage) by PodName, Namespace, TimeGenerated\\r\\n| project Memory, Workload=strcat(Namespace, \\"/\\", PodName), TimeGenerated\\r\\n| order by TimeGenerated asc\\r\\n'

0 commit comments

Comments
 (0)