Skip to content

Facing issues when using msal-browser and msal-react in chrome extension #130

@kiritjoshidev

Description

@kiritjoshidev

Please provide us with the following information:

This issue is for a: (mark with an x)

- [x] bug report -> please search issues before submitting
- [] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Run this sample link with updated msal-browser and msal-react packages

Any log messages given by the failure

Info - handleRedirectPromise called but there is no interaction in progress, returning null.

Expected/desired behavior

I should get authenticated even when there is no redirection

OS and Version?

Windows 11

Versions

@azure/msal-browser": "^3.26.1"
@azure/msal-react": "^2.1.1"

Mention any other details that might be useful

This happens when I return false from onRedirectNavigate in msalConfig which is suggested in this sample.


Thanks! We'll be in touch soon.

Activity

changed the title [-]Facing issues when using msal-broswer and msal-react in chrome extension[/-] [+]Facing issues when using msal-browser and msal-react in chrome extension[/+] on Oct 21, 2024
kiritjoshidev

kiritjoshidev commented on Oct 21, 2024

@kiritjoshidev
Author

Okay, I found the issue. I did not use onRedirectNavigate in instance.loginRedirect to resolve the url and instead used it in msal config as it will be removed in the next major version of msal-browser.

So it will become a problem for extensions once next major release is out.
Can anyone comment on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @kiritjoshidev

        Issue actions

          Facing issues when using msal-browser and msal-react in chrome extension · Issue #130 · Azure-Samples/ms-identity-ciam-javascript-tutorial