Skip to content

Can we provide an option to specify an existing self-hosted runner? #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
autocloudarc opened this issue Aug 30, 2024 · 4 comments
Open
Labels
Area: Bootstrap Modules 👢 Issues / PR's related to the Accelerator bootstrap modules IaC: Bicep Infrastructure as Code - Bicep IaC: Terraform Infrastructure as Code - Terraform Module: Bootstrap Type: Enhancement ✨ New feature or request

Comments

@autocloudarc
Copy link

autocloudarc commented Aug 30, 2024

Description

Rather than only relying only on ALZ provided Azure Container Instances as self-hosted runners, I believe a large majority of cloud engineers and architects may want to leverage their existing GitHub Enterprise [Server, Cloud, or EMU] self-hosted runners that are configured internally as a shared runner at the enterprise or organization level instead.

Describe the solution you'd like

So, to accommodate these scenarios, can we offer an option as a parameter for the Deploy-Accelerator cmdlet to specify the [preferred] name or label of an existing Enterprise or Organizational level self-hosted runner or runner group that these engineers / architects would prefer to use. This way they can implement a simpler and less costly option while utilizing their existing investment in their own self-hosted runner(s).

Describe any alternatives you've considered

For private or internal repositories for GitHub Enterprise members, the alternative is to set the "use_self_hosted_agents:" parameter to "false", but in such cases, the self-hosted runners would then have to be specified in the GitHub Enterprise workflow post ALZ bootstrap, which requires an extra and manual step.

Additional context

@autocloudarc autocloudarc added the enhancement New feature or request label Aug 30, 2024
@jaredfholgate jaredfholgate added the Needs: Triage 🔍 Needs triaging by the team label Sep 2, 2024
@jaredfholgate
Copy link
Member

This is a good idea. We are planning to replace the self-hosted runners code with the https://github.com/Azure/terraform-azurerm-avm-ptn-cicd-agents-and-runners AVM soon. This will allow choosing between ACI, ACA and Azure Managed DevOps Pools. We can also add an option that allows specifying an agent pool or runner group name at the same time.

e.g.

Variables:

  • self_hosted_agent_type - Options: azure_container_instance, azure_container_app, azure_managed_devops_pool, custom
  • self_hosted_agent_pool_name or self-hosted-agent-runner-group - String

@jaredfholgate jaredfholgate added Type: Enhancement ✨ New feature or request Area: Bootstrap Modules 👢 Issues / PR's related to the Accelerator bootstrap modules IaC: Terraform Infrastructure as Code - Terraform IaC: Bicep Infrastructure as Code - Bicep Module: Bootstrap and removed enhancement New feature or request Needs: Triage 🔍 Needs triaging by the team labels Sep 3, 2024
@oZakari oZakari added auto-merge ✔️ Automatically merges and removed auto-merge ✔️ Automatically merges labels Sep 3, 2024
@OskarKlintrot
Copy link

I would suggest adding params for specifying the SKU as well, I tried to use agents, but the SKU wasn't available in my region (Sweden Central).

@jaredfholgate
Copy link
Member

I would suggest adding params for specifying the SKU as well, I tried to use agents, but the SKU wasn't available in my region (Sweden Central).

Could this help in your case @OskarKlintrot? https://azure.github.io/Azure-Landing-Zones/accelerator/troubleshooting/#error-creating-container-group

@OskarKlintrot
Copy link

@jaredfholgate Thanks, that did the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Bootstrap Modules 👢 Issues / PR's related to the Accelerator bootstrap modules IaC: Bicep Infrastructure as Code - Bicep IaC: Terraform Infrastructure as Code - Terraform Module: Bootstrap Type: Enhancement ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants