Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 11296 Fixes - AWS Rule #11415

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Issue 11296 Fixes - AWS Rule #11415

merged 3 commits into from
Nov 15, 2024

Conversation

ashwin-patil
Copy link
Member

Required items, please complete

Change(s):

Reason for Change(s):

  • Modified condition to handle array match

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

@ashwin-patil ashwin-patil requested review from a team as code owners November 12, 2024 03:47
Copy link

Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

@v-prasadboke v-prasadboke self-assigned this Nov 12, 2024
@v-prasadboke v-prasadboke added the Solution Solution specialty review needed label Nov 12, 2024
@v-sudkharat v-sudkharat linked an issue Nov 12, 2024 that may be closed by this pull request
@ashwin-patil
Copy link
Member Author

@microsoft-github-policy-service agree

@v-shukore
Copy link
Contributor

Hi @ashwin-patil, is it correct that only comment has been added in the above query? is the only change which you have done in the query. Thanks...!!

@v-prasadboke v-prasadboke merged commit 88d948a into master Nov 15, 2024
36 checks passed
@ashwin-patil
Copy link
Member Author

Hi @ashwin-patil, is it correct that only comment has been added in the above query? is the only change which you have done in the query. Thanks...!!

Yes, i committed fix already by directly to master by mistake so raised this PR to link issue and updating solution package with actual fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suspicious overly permissive KMS key policy created - Rule Tuning
3 participants